[PWGLF] Possible change in MC trigger definition#16085
Merged
Merged
Conversation
|
O2 linter results: ❌ 2 errors, |
scannito
requested review from
alibuild,
ercolessi,
lhusova,
mpuccio,
omvazque,
romainschotter and
skundu692
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the phi “trigger” is defined in MC by adding an option to build MCGen phi candidates either from true generated phi mesons or from generated K+K− pairs, and it adds toggles affecting pion PID electron rejection and event-level phi presence checks.
Changes:
- Add
trueGenPhioption inPhiMesonCandProducer::processMCGento switch between true-phi based MCGen candidates vs K+K− pair reconstruction. - Add
applyElRejectionoption to enable/disable the electron-rejection block inside pion PID hypotheses rejection. - Add
withTrueGenPhioption to switch the event-level “has phi” decision from a mass-window count to a simple “any candidate exists” check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| if (!(mcParticle1.pdgCode() == PDG_t::kKPlus && mcParticle2.pdgCode() == PDG_t::kKMinus) && | ||
| !(mcParticle1.pdgCode() == PDG_t::kKMinus && mcParticle2.pdgCode() == PDG_t::kKPlus)) | ||
| phimesonCandidatesMcGen(mcCollision.globalIndex(), 0, mcParticle.pt(), mcParticle.y(), mcParticle.phi()); |
Comment on lines
+340
to
+341
| if (!(mcParticle1.pdgCode() == PDG_t::kKPlus && mcParticle2.pdgCode() == PDG_t::kKMinus) && | ||
| !(mcParticle1.pdgCode() == PDG_t::kKMinus && mcParticle2.pdgCode() == PDG_t::kKPlus)) |
Comment on lines
+934
to
+936
| if (withTrueGenPhi) { | ||
| if (phiCandidates.size() < 1) | ||
| return false; |
lhusova
approved these changes
May 4, 2026
SuJeong-Ji
pushed a commit
to SuJeong-Ji/O2Physics
that referenced
this pull request
May 22, 2026
jjuracka
pushed a commit
to jjuracka/O2Physics
that referenced
this pull request
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.