Skip to content

[PWGLF] update strangenesstofpid.cxx to use primary-TOF calibration#14782

Closed
dsekihat wants to merge 1 commit into
AliceO2Group:masterfrom
dsekihat:tof
Closed

[PWGLF] update strangenesstofpid.cxx to use primary-TOF calibration#14782
dsekihat wants to merge 1 commit into
AliceO2Group:masterfrom
dsekihat:tof

Conversation

@dsekihat
Copy link
Copy Markdown
Collaborator

@dsekihat dsekihat commented Feb 3, 2026

This commit aims to use common primary-TOF calibration database in strangeness TOF.
tofEvTimeErr is necessary to accommodate nSigma to this task.
As DauTrackPIDTOF does not have tofEvTimeErr, only processStandard was modified. In order to proceed further, I will have to add DauTrackPIDTOF_002 in LFStrangenessPID.h.
@ddobrigk , @romainschotter Can you review this PR?

@github-actions github-actions Bot added the pwglf label Feb 3, 2026
@dsekihat dsekihat marked this pull request as draft February 3, 2026 14:19
@github-actions github-actions Bot changed the title PWGLF: update strangenesstofpid.cxx to use primary-TOF calibration [PWGLF] update strangenesstofpid.cxx to use primary-TOF calibration Feb 3, 2026
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Mar 25, 2026

@dsekihat Is this still needed?

@vkucera vkucera added the stale label Mar 30, 2026
@dsekihat
Copy link
Copy Markdown
Collaborator Author

dsekihat commented Apr 3, 2026

Yes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2026

O2 linter results: ❌ 131 errors, ⚠️ 137 warnings, 🔕 0 disabled

is_ka_included_TOF = kaonCut.cfg_min_TOFNsigmaKa < track.tofNSigmaKa() && track.tofNSigmaKa() < kaonCut.cfg_max_TOFNsigmaKa;
if (track.tpcInnerParam() < kaonCut.cfg_min_pin_TOFreq) {
return is_ka_included_TPC;
} else {
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless else.

is_ka_included_TOF = kaonCut.cfg_min_TOFNsigmaKa < track.tofNSigmaKa() && track.tofNSigmaKa() < kaonCut.cfg_max_TOFNsigmaKa;
return is_ka_included_TPC && is_ka_included_TOF;
}
} else {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless else.

@github-actions
Copy link
Copy Markdown

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

@github-actions github-actions Bot added the stale label May 23, 2026
@github-actions github-actions Bot closed this May 28, 2026
@dsekihat dsekihat deleted the tof branch June 3, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants