Conversation
This fixes TPC hits in parallel o2-sim depending on which events a worker simulated before. - The hit-grouping state in tpc::Detector::ProcessHits was kept in function-local statics and carried over into the next event. - In parallel mode the next event is any chunk, so the number of empty hit groups varied from run to run. - The state is now a set of detector members that EndOfEvent resets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This fixes the electron count that the TPC detector prints at the end of a run. - The charge of the buffered hit was read after it had been reset to -1. - It is now added before the reset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sawenzel
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
September 25, 2026 09:17
Collaborator
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a small unitialized variable problem and achieves 100% hit reproducibility between any 2 runs of o2-sim.
Fix is by moving from a static var to a class member.