GPUTracking: give Metal its own Float16_t at the conversion site - #15845
Merged
Merged
Conversation
Rather than trying to adapt Ort::Float16_t to work on Metal, we simply alias it to Metal native type, which is bit-to-bit equivalent to the CUDA half implementation and differs from the software one only in the sign of NaN.
Member
Author
|
@davidrohr @ChSonnabend as discussed over coffee. |
davidrohr
approved these changes
Sep 25, 2026
davidrohr
left a comment
Collaborator
There was a problem hiding this comment.
Fine for now, let's clean it up more later.
Member
Author
|
Does not get tested right now. Merging. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 7f83cfa at 2026-09-25 12:58: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than trying to adapt Ort::Float16_t to work on Metal, we
simply alias it to Metal native type, which is bit-to-bit equivalent to the CUDA half
implementation and differs from the software one only in the sign of NaN.