Fix compiler warnings and errors related to dictionaries - #15844
Merged
ktf merged 2 commits intoSep 25, 2026
Merged
Conversation
This fixes the -Winconsistent-missing-override warnings in InteractionSampler.h. - FixedSkipBC_InteractionSampler and NonUniformMuInteractionSampler derive from InteractionSampler, which already has a ClassDef. - Their plain ClassDef produced override warnings for IsA, ShowMembers, Streamer and CheckTObjectHashConsistency. - Both now use ClassDefOverride. https://ali-ci.cern.ch/alice-build-logs/AliceO2Group/AliceO2/15843/ee5503a4c432ac109fab4860dde02f104c65e5a6/build_O2_gpu-test-slc10-x86/pretty.html
This fixes the rootcling "missing ; at end of rule" errors in four LinkDef files. - Three rules in TPCBaseLinkDef.h and the GeometryTGeo rules of ALICE3 ECal, RICH and MID lacked the closing semicolon. - rootcling rejected the three ALICE3 rules, so their GeometryTGeo classes had no dictionary. - The TPC dictionary is unchanged by the fix. https://ali-ci.cern.ch/alice-build-logs/AliceO2Group/AliceO2/15843/ee5503a4c432ac109fab4860dde02f104c65e5a6/build_O2_gpu-test-slc10-x86/pretty.html
sawenzel
requested review from
davidrohr,
fcolamar,
mconcas,
njacazio,
shahor02 and
wiechula
as code owners
September 25, 2026 07:02
Collaborator
Member
|
Currently broken. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compiler warnings and errors related to dictionaries