Fix out-of-range BC slice for ambiguous tracks past the last BC - #15832
Merged
sawenzel merged 1 commit intoSep 23, 2026
Merged
Conversation
This fixes a problem in the AOD producer's BC slice assignment for ambiguous
tracks.
- BunchCrossings::lower_bound returns {size(), 0} when no BC is at or after the
requested one, and fillBCSlice used that pair unchecked.
- A track whose time window starts after the last BC of the timeframe therefore
got fIndexSliceBCs[0] equal to the number of BCs, one past the end of the BC
table.
- The same pair sets the time reference, where 0 - mStartIR.toLong() underflows
in unsigned arithmetic, so fTrackTime was written as about -4.6e20 ns.
- The binary-search implementation that the accelerated lookup replaced clamped
this case to the last BC; fillBCSlice now does the same.
- Seen in LHC26a5a_gp_2025_v10 (Pb-Pb apass1 anchored MC), where 51 of 736770
ambiguous tracks were affected and later crashed the AnalysisQC event
selection QA task.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem in the AOD producer's BC slice assignment for ambiguous tracks.