[TF3] Implement cluster finder for multiple digits in same chip - #15748
Merged
Merged
Conversation
Marcellocosti
force-pushed
the
tof_staves
branch
2 times, most recently
from
September 8, 2026 17:37
0c3855e to
e5e7678
Compare
Marcellocosti
force-pushed
the
tof_staves
branch
from
September 15, 2026 16:28
5a97d49 to
0304df9
Compare
Marcellocosti
added a commit
to Marcellocosti/AliceO2
that referenced
this pull request
Sep 15, 2026
Please consider the following formatting changes to AliceO2Group#15748
Marcellocosti
force-pushed
the
tof_staves
branch
from
September 18, 2026 14:07
0b0b6a3 to
94eb37a
Compare
…in central framework + add macro test in cmake list
fix stepping for both passive and active pixel edges + revert change in central framework + add macro test in cmake list
Please consider the following formatting changes to AliceO2Group#15748
Contributor
Author
Distribution of generated clusters for inner and outer tof
|
Contributor
Author
Cluster-hit residuals for both ITOF and OTOF when running with squared pixels (pitch 250 μm), hit propagation with 10 steps, pixel passive edges 10μm. |
Contributor
Author
Comparison of digit and cluster efficiencies
|
Marcellocosti
marked this pull request as ready for review
September 22, 2026 10:43
Marcellocosti
requested review from
fcolamar,
mconcas and
njacazio
as code owners
September 22, 2026 10:43
Collaborator
Contributor
Author
|
@njacazio can you enable merging? The implementation is now complete, thanks! |
Collaborator
njacazio
enabled auto-merge (squash)
September 23, 2026 04:00
njacazio
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, the cluster finder of ALICE3 TOF can identify clusters of digits within the same pixel which satisfy spatial and timing constraints. The different topologies are handled in the class
TopologyClassifier, which assigns cluster topologies based on column and row span and the matrix of fired pixels. This class produces a topology dictionary which is dumped to a.rootfile, allowing for a detailed offline study of the cluster topologies.I also thought of moving the
Segmentationclass toIOTOFBase, since it is needed by both the digitizer and cluster finder.Drafting since the implementation of the COG computation still needs some minor work, debug prints will be removed before opening.
Tagging @maciacco @njacazio, please let me know if you have any suggestion!