Skip to content

GPU/TPC: extend noisy pad filter with Highly Ionising Particle filter#15424

Open
fweig wants to merge 9 commits into
AliceO2Group:devfrom
fweig:hip-tail-cluster-pr
Open

GPU/TPC: extend noisy pad filter with Highly Ionising Particle filter#15424
fweig wants to merge 9 commits into
AliceO2Group:devfrom
fweig:hip-tail-cluster-pr

Conversation

@fweig
Copy link
Copy Markdown
Contributor

@fweig fweig commented May 22, 2026

Supersedes #15180:

  • Fixed issue where filter missed saturated bins
  • Added rising edge detection
  • Added exponential filter for tail cutoff
  • Added Cluster creation

@fweig fweig requested review from a team and davidrohr as code owners May 22, 2026 13:50
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 7376b5c at 2026-05-26 16:39:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/GPU/Common/GPUCommonMath.h:499:10: error: no matching function for call to 'atomic_add'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for a53a04b at 2026-05-27 13:33:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/GPU/Common/GPUCommonMath.h:499:10: error: no matching function for call to 'atomic_add'
ninja: build stopped: subcommand failed.

Full log here.

@davidrohr
Copy link
Copy Markdown
Collaborator

@fweig : this seems to be a legit error:

GPUChainTrackingClusterizer.cxx:283:20: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'result_type' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
  283 |   std::mt19937 gen{seed};
      |                    ^~~~
/Volumes/build/alice-ci-workdir/o2/sw/SOURCES/O2/15424/0/GPU/GPUTracking/Global/GPUChainTrackingClusterizer.cxx:283:20: note: insert an explicit cast to silence this issue
  283 |   std::mt19937 gen{seed};
      |                    ^~~~
      |                    static_cast<result_type>( )
1 error generated.

@fweig fweig force-pushed the hip-tail-cluster-pr branch from 918b923 to c2707f5 Compare May 28, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants