feat(deps): remove magic dependency#305
Merged
Merged
Conversation
luabida
force-pushed
the
remove-magic-dep
branch
2 times, most recently
from
968fa1c to
c86a76a
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
=======================================
Coverage ? 97.84%
=======================================
Files ? 49
Lines ? 8499
Branches ? 0
=======================================
Hits ? 8316
Misses ? 183
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
luabida
force-pushed
the
remove-magic-dep
branch
from
c86a76a to
c8061f7
Compare
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python Magic is very good for handling an enormous amount of file extensions, but he caveat is that it is tricky when installing on windows and causes unnecessary dependency errors on other archs. therefore, Im removing the MIME detection via C magic and read the headers of the files instead