-
Notifications
You must be signed in to change notification settings - Fork 686
fix(frontend): stop showing a stale model catalog for a rejected key #6472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -182,6 +182,7 @@ const ProviderConnectionCard = ({ | |
|
|
||
| const credentialStatus = probe?.credential.status ?? null | ||
| const discovered = probe?.discovery.status === "fetched" | ||
| const discoveryStatus = probe?.discovery.status ?? null | ||
|
|
||
| // Standard providers name a family the harness catalog knows; the credential-set kinds carry | ||
| // whatever the endpoint serves, so their list comes from discovery and manual entry alone. | ||
|
|
@@ -469,8 +470,10 @@ const ProviderConnectionCard = ({ | |
| > | ||
| {credentialFailed ? ( | ||
| <WarningCircle size={14} className="mt-0.5 shrink-0" /> | ||
| ) : ( | ||
| ) : credentialStatus === "valid" ? ( | ||
| <span className="mt-1.5 size-1.5 shrink-0 rounded-full bg-colorSuccess" /> | ||
| ) : ( | ||
| <span className="mt-1.5 size-1.5 shrink-0 rounded-full bg-colorWarning" /> | ||
|
Comment on lines
470
to
+476
Comment on lines
+473
to
+476
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Use non-success text styling for unconfirmed credentials. The new amber dot is inside a parent span that still uses |
||
| )} | ||
| <span> | ||
| {statusLine} | ||
|
|
@@ -514,6 +517,8 @@ const ProviderConnectionCard = ({ | |
| <ActiveModelsSection | ||
| options={modelOptions} | ||
| manualPlaceholder={manualModelPlaceholderForKind(kind)} | ||
| title={title} | ||
| discoveryStatus={discoveryStatus} | ||
| onToggle={toggleModel} | ||
| onSelectAll={() => setCheckedModels(modelOptions.map((option) => option.id))} | ||
| onClear={() => setCheckedModels([])} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Render the catalog note only for an actual catalog fallback.
discoveryStatus !== "fetched"does not prove that the displayed options came from Agenta's shipped catalog. Credential-set providers are documented as discovery- and manual-entry-only, so this text can claim a catalog is shown when it is not. Pass an explicit fallback flag and gate this note on that flag.