Skip to content

[WE-427] chore: migrate from volta to mise for node version management#1248

Merged
arshabh-agarwal merged 5 commits into
masterfrom
arshabh-agarwal/WE-427-volta-to-mise-migration
Jul 16, 2026
Merged

[WE-427] chore: migrate from volta to mise for node version management#1248
arshabh-agarwal merged 5 commits into
masterfrom
arshabh-agarwal/WE-427-volta-to-mise-migration

Conversation

@arshabh-agarwal

@arshabh-agarwal arshabh-agarwal commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

WE-427

  • Created mise.toml and mise.lock with Node 18.20.5 (from volta config)
  • Removed volta block from package.json
  • Added packageManager field for yarn@1.22.19
  • Updated CI workflow to use jdx/mise-action@v4 (public action, since ember-table is a public repo and cannot access internal Addepar actions)
  • Added corepack enable step for yarn support
  • Pinned testem to <3.19.0 via resolutions to avoid ESM execa incompatibility on Node 18

Test plan

  • CI workflows pass (lint, test)
  • mise exec -- node --version returns v18.20.5
  • yarn install resolves deps

Note: The ember-release scenario fails because ember-source@7.x requires Node >= 20.19. This is a pre-existing issue unrelated to the mise migration — upgrading Node and ember-cli should be done in a separate PR.

[WE-427]
- Created mise.toml and mise.lock with node 18.20.5 from volta config
- Removed volta block from package.json
- Added packageManager field for yarn@1.22.19
- Updated CI workflow to use setup-node-toolchain
@arshabh-agarwal
arshabh-agarwal requested review from a team and bantic July 13, 2026 07:44
ember-table is a public repo and cannot access actions from internal
repos. Replace Addepar/web-templates/actions/setup-node-toolchain with
jdx/mise-action@v4 and add corepack enable step for yarn.
testem@3.19.0+ depends on execa@^9.6.1 which is ESM-only. When
ember-try scenarios resolve fresh dependencies, testem gets upgraded
past 3.18.0 causing ERR_REQUIRE_ESM failures on Node 18. Pin testem
to <3.19.0 via resolutions to keep CJS-compatible execa@^1.0.0.
- Upgrade Node from 18.20.5 to 24.18.0 (active LTS)
- Upgrade ember-cli from ~3.28.0 to ~5.12.0
- Upgrade ember-source from ~3.28.0 to ~5.12.0 (default dev)
- Update engines field to >= 20.19.0
- Remove testem resolution (Node 24 supports require(esm) natively)
- Regenerate yarn.lock
@arshabh-agarwal
arshabh-agarwal merged commit c72d488 into master Jul 16, 2026
8 of 9 checks passed
@arshabh-agarwal
arshabh-agarwal deleted the arshabh-agarwal/WE-427-volta-to-mise-migration branch July 16, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants