Skip to content

Remove inert NuGet target files - #199

Merged
AdamEssenmacher merged 2 commits into
mainfrom
codex/remove-inert-targets
Aug 29, 2026
Merged

AdamEssenmacher merged 2 commits into
mainfrom
codex/remove-inert-targets

Conversation

@AdamEssenmacher

@AdamEssenmacher AdamEssenmacher commented Aug 29, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • remove ten packaged .targets files that only assigned unused private assembly-name properties
  • remove their corresponding build/ and buildTransitive/ pack entries
  • remove the deleted Firebase target paths from the release updater
  • leave every target file with executable, item, or import behavior unchanged

Validation

  • dotnet tool restore
  • packed all ten affected components together with the repository Cake nuget target
  • inspected all ten resulting NuGet archives and confirmed they contain no .targets entries
  • built a Release net10.0-ios simulator consumer with direct references to all ten packages
  • built a Release net10.0-ios simulator consumer through a class library with all ten packages present in the transitive asset graph
  • compiled the Firebase release task graph with Cake --dryrun and verified its remaining managed target path exists

Both consumer builds completed with no package or linker errors.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-29T18:10:43.959853Z 3bf490c New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 72909e59bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread source/Firebase/Analytics/Analytics.targets
@AdamEssenmacher
AdamEssenmacher merged commit 444a59d into main Aug 29, 2026
1 check passed
@AdamEssenmacher
AdamEssenmacher deleted the codex/remove-inert-targets branch August 29, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant