Skip to content

Fix Crashlytics symbol upload default guard - #198

Merged
AdamEssenmacher merged 1 commit into
mainfrom
codex/fix-crashlytics-props
Aug 29, 2026
Merged

AdamEssenmacher merged 1 commit into
mainfrom
codex/fix-crashlytics-props

Conversation

@AdamEssenmacher

Copy link
Copy Markdown
Owner

Summary

  • correct the Crashlytics symbol-upload default guard to check the property it assigns
  • preserve an explicit value supplied before the NuGet props import

Validation

  • verified a pre-set False value remains False in Release
  • verified an unset Release value defaults to True
  • verified an unset Debug value remains empty
  • ran dotnet tool run dotnet-cake -- --target=nuget --names=Firebase.Crashlytics successfully with zero warnings and errors
  • confirmed the corrected props file is present under both build and buildTransitive in the generated package

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-29T17:49:43.261824Z 0c251f1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdamEssenmacher
AdamEssenmacher merged commit 539a272 into main Aug 29, 2026
1 check passed
@AdamEssenmacher
AdamEssenmacher deleted the codex/fix-crashlytics-props branch August 29, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant