Skip to content

Remove obsolete Google Sign-In resource targets - #197

Merged
AdamEssenmacher merged 1 commit into
mainfrom
codex/remove-obsolete-signin-targets
Aug 29, 2026
Merged

AdamEssenmacher merged 1 commit into
mainfrom
codex/remove-obsolete-signin-targets

Conversation

@AdamEssenmacher

Copy link
Copy Markdown
Owner

Summary

  • stop packing the obsolete SignIn targets into build and buildTransitive
  • remove the unreachable manual GoogleSignIn.bundle resource declarations
  • rely on the dynamic GoogleSignIn.framework to carry its nested resource bundle

Why

The target was never scheduled, checked ResourcesBaseFolder while defining _ResourcesBaseFolder, and hard-coded the old net9.0-ios package path. The dynamic framework already contains the resource bundle, so the target was both ineffective and unnecessary.

Validation

  • packed Google.SignIn with zero warnings or errors
  • built direct and transitive .NET 10 iOS consumers
  • built a .NET 10 Mac Catalyst consumer
  • verified the framework-nested 44-file bundle is present and linked
  • verified no duplicate app-root bundle is emitted

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-29T17:34:44.801896Z 887aab9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdamEssenmacher
AdamEssenmacher merged commit 9784b73 into main Aug 29, 2026
1 check passed
@AdamEssenmacher
AdamEssenmacher deleted the codex/remove-obsolete-signin-targets branch August 29, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant