Skip to content

fix(android): fix invalid single-instance path - #576

Draft
0xbrayo wants to merge 2 commits into
ActivityWatch:masterfrom
0xbrayo:fix-single-instance-android
Draft

0xbrayo wants to merge 2 commits into
ActivityWatch:masterfrom
0xbrayo:fix-single-instance-android

Conversation

@0xbrayo

@0xbrayo 0xbrayo commented Mar 20, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Mar 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.31%. Comparing base (656f3c9) to head (9b4c535).
⚠️ Report is 218 commits behind head on master.

Files with missing lines Patch % Lines
aw-client-rust/src/single_instance.rs 83.33% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #576       +/-   ##
===========================================
+ Coverage   70.81%   85.31%   +14.50%     
===========================================
  Files          51       87       +36     
  Lines        2916    12477     +9561     
===========================================
+ Hits         2065    10645     +8580     
- Misses        851     1832      +981     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xbrayo
0xbrayo force-pushed the fix-single-instance-android branch from 475ebb8 to e9159cc Compare October 19, 2026 11:41
@0xbrayo

0xbrayo commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

🤖 Claude, on behalf of @0xbrayo

@greptile review

@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

The PR replaces Android’s hardcoded lock directory with an app-specific path.

  • Android clients keep their single-instance lock in the app cache.

Reviews (2) · Last reviewed commit: "fix(android): take the lock dir from the..." · Reviewed by Greptile

Comment thread aw-client-rust/src/single_instance.rs Outdated
@0xbrayo

0xbrayo commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

🤖 Claude, on behalf of @0xbrayo

@greptile review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant