Align BankID app autostart with current BankID guidelines - #548
Draft
torselden wants to merge 3 commits into
Draft
Align BankID app autostart with current BankID guidelines#548torselden wants to merge 3 commits into
torselden wants to merge 3 commits into
Conversation
…vice Keep autostart as default on iOS; limit manual-launch fallback to restricted Android browsers Restores autostart as the default per BankID's autostart guidance and scopes the user-interaction fallback to Android browsers that block app launch without a user gesture (excluding Firefox/Opera). Keeps the app-link URL and anchor-based launch from #526. Adds launcher tests for URL selection and interaction behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates how Active Login launches the BankID app so it follows BankID's current autostart guidance. Autostart is the default on all supported devices, the recommended universal/app link is used on mobile, and the manual launch button is only shown as a fallback where a browser actually requires user interaction.
This PR fixes #534
High level overview of this PR
These things have been implemented (when relevant)
Backwards-compatibility note
This PR changes the launch URL selection for several device/browser combinations (no public API changes):
CanUseAppLink no longer restricts the app link to Safari-on-iOS and Chrome/Edge-on-Android ≥ 6 — it now applies to every iOS and Android browser. The DeviceOsVersion.MajorVersion >= 6 guard was removed.
As a result, iOS non-Safari (Chrome, Firefox, Edge, Opera) and Android Firefox/Opera / older Android now receive https://app.bankid.com/… where they previously received bankid:///…. This matches current BankID guidance and should improve reliability.
The manual "start BankID" fallback button is now scoped to restricted Android browsers instead of a broader set.
What consumers should verify: if you relied on the old scheme-based launch for a specific browser, that path changes. Android Firefox/Opera in particular should be verified on real devices, since their historical app-link/intent handling has been inconsistent. Custom IBankIdLauncher / IBankIdSupportedDeviceDetector implementations are unaffected, and the deprecated redirect query parameter is still emitted, so BankID app compatibility is preserved.