fix(setup): skip admob plugin for paid apk builds#2118
Conversation
Greptile SummaryThis PR adds a
Confidence Score: 5/5The change is safe to merge; the admob-skip logic is straightforward and the failure path (missing config.xml) surfaces a clear error rather than silently misbehaving. The core logic — read widget ID, compare against a constant, gate plugin installation — is simple and correctly implemented. All three issues raised in prior review rounds are resolved. The only remaining notes are a minor regex strictness opportunity and an unrelated lock-file entry, neither of which affects correctness. No files require special attention; the unrelated proot entry in bun.lock is worth a quick confirmation from the author but poses no risk. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[setup.js starts] --> B[installDependencies]
B --> C[cordova platform add android]
C --> D[cordova plugin add buildinfo / device / file]
D --> E[isPaidVersion]
E --> F[readFileSync config.xml]
F -->|file missing| G[throw descriptive Error]
F -->|file read| H[regex match widget id]
H -->|id == com.foxdebug.acode| I[shouldSkipAdmob = true]
H -->|id != com.foxdebug.acode or no match| J[shouldSkipAdmob = false]
I --> K[iterate src/plugins]
J --> K
K -->|plugin == admob AND shouldSkipAdmob| L[skip admob]
K -->|other plugins| M[cordova plugin add plugin]
L --> N[done]
M --> N
Reviews (3): Last reviewed commit: "fix" | Re-trigger Greptile |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@greptile review again |
No description provided.