PageObject retirement keys and the two unlinked-Feature conditions - #45
Merged
Merged
Conversation
DEC-47 keeps deprecation_reason and superseded_by authored on a Feature, but the canon disagreed on where. The common-mistakes row and examples_check (which already reads both keys from a full header to mark a Feature retiring) put them on a PageObject header; section 2's field table and the glossary's "where authored" note left them out. The canon also called a Feature with `user_stories: none` "orphan", and the tools turned that word into one code for two conditions (DEC-48). The canon now names the condition in words and restates no tool code. - header types, section 2: deprecation_reason and superseded_by as optional full-header fields that drive no state; both join the cross-reference header's intentionally omitted list - glossary: the two PageObject keys named next to the issue-body headings and the feature-file keys - header types: "orphan(ed)" becomes "with no User Story" in the adoption table, the user_stories row and the maintenance note - examples_check unchanged: it already accepts both keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEC-47 keeps deprecation_reason and superseded_by authored on a Feature, but the canon disagreed on where. The common-mistakes row and examples_check (which already reads both keys from a full header to mark a Feature retiring) put them on a PageObject header; section 2's field table and the glossary's "where authored" note left them out.
The canon also called a Feature with
user_stories: none"orphan", and the tools turned that word into one code for two conditions (DEC-48). The canon now names the condition in words and restates no tool code.