Skip to content

feat(wallet_screening): paginate Etherscan txlist and surface warnings (#214)#215

Open
Hendobox wants to merge 2 commits into
ARPAHLS:mainfrom
Hendobox:feat/issue-115-3b-etherscan-pagination
Open

feat(wallet_screening): paginate Etherscan txlist and surface warnings (#214)#215
Hendobox wants to merge 2 commits into
ARPAHLS:mainfrom
Hendobox:feat/issue-115-3b-etherscan-pagination

Conversation

@Hendobox

@Hendobox Hendobox commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Paginate Etherscan account.txlist (1k per page, cap 10k txs)
  • Add metadata.warnings when history is truncated or unavailable
  • Update agent instructions.md and bundle tests (mocked only)

Fixes #214 · Part of #115

Test plan

  • pytest skills/finance/wallet_screening/test_skill.py tests/skills/finance/test_wallet_screening.py -q (18 passed)
  • flake8 + black on changed files

ARPAHLS#214)

Fetch account txlist in pages (cap 10k txs), emit metadata.warnings when
history is truncated or unavailable, and add mocked bundle tests plus
agent instructions. Part of ARPAHLS#115.
@Hendobox

Hendobox commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@rosspeili #214 ready - Etherscan txlist pagination + metadata.warnings, instructions + tests. Scoped like #128/#140. Fixes #214 · part of #115.

@rosspeili

Copy link
Copy Markdown
Contributor

Hey @Hendobox, thanks for picking up another clean #115 slice.

A small tip before merge, would be nice to have a line in docs/skills/wallet_screening.md about the 10k cap and warning codes would help operators who don’t read instructions.md first (fine as a follow-up if you prefer to keep this PR tight).

I’ll update the pinned #115 comment to mark #214 / #215 as in review under Ph 2.2b (slice). Happy to merge once CI is green. Nice work continuing the RFC pattern from #128 / #140. <3

…PAHLS#214)

Update catalog Limitations so operators see pagination caps and
metadata.warnings without reading instructions.md first.
@Hendobox

Hendobox commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @rosspeili — added the catalog note in docs/skills/wallet_screening.md (Limitations): paginated 10k cap + metadata.warnings codes (etherscan_txlist_truncated / unavailable / partial). Pushed on this PR so ops don’t have to dig into instructions.md. CI was already green; this should be a quick re-check. 🙏

@rosspeili

Copy link
Copy Markdown
Contributor

@Hendobox Thanks for the quick follow-up,

This looks tight, I only see a conflict on changelog since we had 2 releases cut today, but it's a quick rebase fix. Also in terms of data schema, maybe add optional metadata.warnings to the JSON example in docs/skills/wallet_screening.md (eg. "warnings": ["etherscan_txlist_truncated"]) so the catalog matches the new output shape, also not sure if we need to do it now or when all items finish, bumping manifest.yaml version (eg 1.0.01.0.1) for the user-visible output change, or you want to make it 2.0.0 when the rfc is done? 100% up to you.

Once CI is green on the rebased branch, we’re good to merge. Thanks for continuing to this RFC and web3 area of Skillware bro <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wallet_screening] 3b: Etherscan txlist pagination + truncation warnings (parent: #115)

2 participants