chore: post-#123 cleanup for agent bash path#124
Merged
Conversation
Remove machine-local .cargo cross-compile config, bump open-agent-sdk for shell override warn/tests, and document Git Bash path examples in settings i18n (related to #120).
There was a problem hiding this comment.
Pull request overview
This PR is a post-merge cleanup related to the newly configurable Agent Bash executable path on Windows, focusing on user-facing settings copy and removing a machine-local Cargo configuration from the repo.
Changes:
- Clarify the Git Bash executable path examples in zh-CN and en-US settings copy (including guidance to use
bash.exeinstead ofgit-bash.exe). - Remove
.cargo/config.tomlthat contained a machine-/environment-specific MinGW linker override.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/i18n/locales/zh-CN.json |
Updates the Bash Path setting description with a concrete Windows Git Bash example. |
src/i18n/locales/en-US.json |
Updates the Bash Path setting description with a concrete Windows Git Bash example. |
.cargo/config.toml |
Removes a machine-local cross-compile linker configuration from the repository. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
496
to
499
| "agentWorkspacePreview": "Preview: {{value}}", | ||
| "agentBashPath": "Bash Path", | ||
| "agentBashPathDesc": "Path to the Bash executable used for Agent commands. Leave empty to auto-detect from PATH.", | ||
| "agentBashPathDesc": "Path to the Bash executable used for Agent commands. Leave empty to auto-detect from PATH. On Windows with Git, use e.g. C:\\Program Files\\Git\\bin\\bash.exe (not git-bash.exe).", | ||
| "agentBashPathPlaceholder": "Leave empty for auto-detection", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up after merging #123 / fixing #120:
.cargo/config.toml(mingw cross-compile linker — should not live in the main repo)open-agent-sdkto include warn + unit tests whenshell_binarypath is missingRelated
Test plan
cargo test --lib tools::bash::testsin open-agent-sdk (6 passed).cargo/config.tomlon main after merge