Add option to use Tokamax attention API in MaxText.#3949
Open
copybara-service[bot] wants to merge 1 commit into
Open
Add option to use Tokamax attention API in MaxText.#3949copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
PiperOrigin-RevId: 912831162
copybara-service
Bot
force-pushed
the
test_912831162
branch
from
e90bb2a to
7c47071
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
gobbleturk
reviewed
May 20, 2026
| local_window_size = (self.sliding_window_size, self.sliding_window_size) | ||
|
|
||
| scale = 1.0 / math.sqrt(query.shape[-1]) | ||
| attention_output = tokamax_attention_api.dot_product_attention( |
Collaborator
There was a problem hiding this comment.
tbh this makes me sad, I want to call kernels with block sizes I am not a fan of high level APIs like this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to use Tokamax attention API in MaxText.