PLATFORM-7428: Allow to use multiple schemes when configuring identity tests - #366
Merged
Conversation
vfateev
approved these changes
Jul 15, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the authorization/identity test configuration UI to support selecting multiple credential schemes for “Source” and “Target”, and includes a couple of small capture-app import cleanups.
Changes:
- Make
DownshiftSelect’slabeloptional so it can be reused in grouped/array layouts. - Replace single
source.0/target.0selects with a dynamicuseFieldArray-driven UI that supports adding/removing multiple entries. - Fix/clean imports in the capture app (
openLinkimport source, remove unused general error imports).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/web/src/new-components/fat-fields/DownshiftSelect.tsx | Allows omitting the field label so selects can be embedded inside grouped/array UIs. |
| packages/web/src/app/scanconf/authorizationTests/TestContents.tsx | Introduces AuthArrayField to add/remove multiple Source/Target schemes. |
| packages/web/src/app/capture/Subscription.tsx | Updates openLink import to use the capture-local slice. |
| packages/web/src/app/capture/index.tsx | Removes unused general error imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+48
to
+53
| <Remove | ||
| onClick={(e) => { | ||
| e.preventDefault(); | ||
| e.stopPropagation(); | ||
| remove(index); | ||
| }} |
Comment on lines
+119
to
+130
| const Add = styled.div` | ||
| display: flex; | ||
| padding: 8px 12px; | ||
| gap: 4px; | ||
| cursor: pointer; | ||
| align-items: center; | ||
| border: 1px dashed var(${ThemeColorVariables.border}); | ||
| color: var(${ThemeColorVariables.linkForeground}); | ||
| > svg { | ||
| fill: var(${ThemeColorVariables.linkForeground}); | ||
| } | ||
| `; |
Comment on lines
+59
to
+65
| <Add | ||
| onClick={(e) => { | ||
| e.preventDefault(); | ||
| e.stopPropagation(); | ||
| append(""); | ||
| }} | ||
| > |
| <GroupLabel>{label}</GroupLabel> | ||
| {fields.map((field, index) => ( | ||
| <Row key={field.id}> | ||
| <DownshiftSelect name={`${name}.${index}`} options={options} /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.