fix(theme): correct marks and unavailable previews - #941
Open
huyanxius wants to merge 9 commits into
Open
Conversation
External marks can retain stale colors. Add an inline mark with isolated masks. The mark follows surrounding text.
Navigation retains external marks and a bright inset line. Use inline marks and remove the inset shadow. Navigation follows the page palette.
The panel loads a cached external mark. Render the shared inline mark. The mark inherits panel text color.
The default avatar loads a cached external mark. Render the shared inline mark. The avatar follows account text color.
The footer loads a cached external mark. Render the shared inline mark. The footer mark follows its text color.
The favicon URL has an immutable cache lifetime. Version the updated favicon reference. Browsers request the theme-aware asset.
Failed sources leave broken images in preview cards. Show a status after the original image fails. Thumbnail fallback and changed URLs remain usable.
Failed sources need explicit recovery coverage. Exercise fallback and replacement URLs. Regressions in failure handling are detected.
Default account marks now render inline. Assert their decorative accessibility contract. Existing account behavior remains covered.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #941 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 193 193
Lines 13204 13204
=======================================
Hits 12052 12052
Misses 1152 1152
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复主题发布后的标志缓存、导航亮线和预览图失败显示。
Why
固定 SVG 地址被生产缓存七天，旧浏览器可能保留黑色标志；导航浅色内阴影形成亮线。旧媒体域名返回
419 user disabled，预览台直接显示破图。Changes
Verification
vitest run src/shared/ui/asset-preview-card.test.tsx src/app/layout/app-header.test.tsx src/pages/account/index.test.tsx：71 项通过；新增的 2 项回归测试修复前失败、修复后通过。npm run build：通过。改动文件
oxlint、oxfmt、git diff --check：通过。本地浏览器：标志填色分别为
rgb(37,37,34)/rgb(232,232,232)；导航box-shadow: none；失败图片显示占位提示。Scope
仅修复显示，不恢复旧存储账号或迁移历史图片；新空间配置、数据库和服务器均未修改。旧图仍需恢复存储访问后才能重新显示。
Related Issues
Closes #940