Repository navigation
fix: never run the settings workflow in a fork - #82
Merged
Merged
Conversation
settings.yml applies this repository's own settings. In a fork it would apply them to the fork on every push, every day on the schedule and on a manual run. The job now runs only in 030/settings-action. It checks github.repository rather than github.event.repository.fork, because a schedule event has no repository in its payload. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/settings.ymlapplies the settings of this repository with the action itself. In a fork, such asschubergphilis/settings-action, it would apply them to the fork on every push tomain(including a fork sync), daily on the schedule and on a manual run, and fail where the fork lacks theSETTINGS_ACTIONsecret.The
settings-actionjob now hasif: github.repository == '030/settings-action', so in a fork it is skipped. It does not checkgithub.event.repository.fork: the payload of ascheduleevent has norepository, so that check would let the daily run through in a fork.Testing
yamllint and actionlint pass. In this repository the job runs as before; the skip can only be observed in a fork after this is merged.
🤖 Generated with Claude Code