From db15213d761abdbd7db57afda432e37ce684d16d Mon Sep 17 00:00:00 2001 From: Andrei Pokhilko Date: Wed, 2 Sep 2026 22:06:18 +0100 Subject: [PATCH] Fix AutoStop doc and test comment wording Follow-up to #883: - reword a test comment that referenced the reviewer by name - correct the wiki, which said the percentile rank is in milliseconds Co-Authored-By: Claude Opus 5 --- .../src/test/java/kg/apc/jmeter/reporters/AutoStopTest.java | 2 +- site/dat/wiki/AutoStop.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/autostop/src/test/java/kg/apc/jmeter/reporters/AutoStopTest.java b/plugins/autostop/src/test/java/kg/apc/jmeter/reporters/AutoStopTest.java index 5b37706a3..a9938c067 100644 --- a/plugins/autostop/src/test/java/kg/apc/jmeter/reporters/AutoStopTest.java +++ b/plugins/autostop/src/test/java/kg/apc/jmeter/reporters/AutoStopTest.java @@ -290,7 +290,7 @@ public void testRelativeWindowDisabledWhenNotConfigured() throws InterruptedExce System.out.println("relativeWindowDisabledWhenNotConfigured"); System.clearProperty("auto_stopped"); AutoStop instance = new AutoStop(); - // Rank blank, window and threshold set (Andrei's reproduction case) + // Rank blank, window and threshold set: must not fall back to comparing P0 instance.setRelWindowSecs("1"); instance.setRelThresholdPct("10"); instance.testStarted(); diff --git a/site/dat/wiki/AutoStop.md b/site/dat/wiki/AutoStop.md index 7b3d8e8fc..f4fed2a0d 100644 --- a/site/dat/wiki/AutoStop.md +++ b/site/dat/wiki/AutoStop.md @@ -29,7 +29,7 @@ To disable auto-stop on rate criteria, just set error rate to zero. ## AutoStop on Percentile Response Time -Percentile rank and threshold specified in milliseconds. +Percentile rank specified as a number, e.g. 90 for P90; the threshold is specified in milliseconds. Test will be stopped only if specified percentile response time exceeded for *sequentially* N seconds. ## AutoStop on Relative Window Percentile Degradation