Skip to content

Commit 3a35c5a

Browse files
brianstrauchclaude
andcommitted
Fix stale sample and test wiring
Four unrelated papercuts: - Add the llm-stream dependency group. workflow_streams/README.md tells readers to run `uv sync --group llm-stream` for scenario 5, but the group was never created, so the command fails. The sample's openai import resolves today only because the langfuse-tracing and langsmith-tracing groups happen to install openai. - Rename tests/activity_sticky_queues to tests/worker_specific_task_queues, and drop the stale prefix from the two test filenames. The sample was renamed but its test directory was not, so the tests sat under a directory naming a sample that no longer exists. - Locate google_genai's echo MCP server through the installed package rather than Path(__file__).parents[2], which hardcodes the distance from the test file to the sample and silently resolves to a nonexistent path if either moves. A missing server script makes the test hang rather than fail, since the client waits on a subprocess that never started. - Add __init__.py to the five test directories that lacked it. Test filenames collide across samples by design (workflow_test.py, activity_test.py and mcp_test.py each appear in several), and package markers are what keep pytest from treating them as the same module. The five worked only because they had not collided yet. Full suite unchanged at 150 collected, 148 passed, 4 skipped; mypy clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 0e2b6ed commit 3a35c5a

16 files changed

Lines changed: 7 additions & 3 deletions

File tree

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ langgraph = [
7474
"temporalio[langgraph,langsmith]>=1.31.0",
7575
]
7676
litellm = ["litellm>=1.85.0,<2"]
77+
llm-stream = ["openai>=1.4.0"]
7778
nexus = ["nexus-rpc>=1.1.0,<2"]
7879
open-telemetry = [
7980
"temporalio[opentelemetry]",

tests/google_genai/mcp_test.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@
1717
)
1818
from temporalio.worker import Worker
1919

20+
import google_genai.mcp as google_genai_mcp
2021
from google_genai.mcp.workflow import McpWorkflow
2122

22-
ECHO_SERVER = str(
23-
Path(__file__).parents[2] / "google_genai" / "mcp" / "echo_mcp_server.py"
24-
)
23+
ECHO_SERVER = str(Path(google_genai_mcp.__file__).parent / "echo_mcp_server.py")
2524

2625

2726
@asynccontextmanager

tests/message_passing/__init__.py

Whitespace-only changes.

tests/message_passing/introduction/__init__.py

Whitespace-only changes.

tests/message_passing/lazy_initialization/__init__.py

Whitespace-only changes.

tests/message_passing/safe_message_handlers/__init__.py

Whitespace-only changes.

tests/message_passing/waiting_for_handlers/__init__.py

Whitespace-only changes.

tests/message_passing/waiting_for_handlers_and_compensation/__init__.py

Whitespace-only changes.

tests/nexus_messaging/__init__.py

Whitespace-only changes.

0 commit comments

Comments
 (0)