Strip proxy-authorization header by default.#348
Open
FletcherDares wants to merge 2 commits into
Open
Conversation
samuel-williams-shopify
changed the title
proxy-authorization header by defaultproxy-authorization header by default.
There was a problem hiding this comment.
Pull request overview
This PR hardens Falcon’s proxy middleware by ensuring the Proxy-Authorization header is stripped before forwarding requests upstream, preventing unintended exposure of proxy credentials and aligning with RFC 7235 §4.4.
Changes:
- Add
proxy-authorizationto the proxy middleware’s hop-by-hop header removal list. - Add a middleware unit test verifying
proxy-authorizationis removed while preservingauthorization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/falcon/middleware/proxy.rb |
Strips proxy-authorization as a hop-by-hop header during header preparation. |
test/falcon/middleware/proxy.rb |
Adds coverage to ensure proxy-authorization is removed by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strip
Proxy-Authorizationin the proxy middleware before forwarding requests upstream.Forwarding the
Proxy-Authorizationit through Falcon's reverse proxy can expose proxy credentials to upstream applications that did not request them. It should also be stripped under RFC 7235 S4.4