Commit f690e9b
committed
fix(excel): request the SharePoint scopes the file picker needs
The Excel block exposes a SharePoint site picker and a drive picker, and
builds `/drives/{driveId}/items/{id}` for arbitrary drives, but the
integration only requested `Files.Read` and `Files.ReadWrite`. Those cover
the signed-in user's own OneDrive, so a workbook in a document library
came back as insufficient privileges and the drive picker's
`GET /sites/{id}/drives` call failed outright.
Add `Files.Read.All`, `Files.ReadWrite.All` and `Sites.Read.All`. Word
already carries the first two for exactly this reason. All are
user-consentable, so this does not push Excel behind admin consent, and
none grants access to anything the signed-in account could not already
open.
Microsoft only grants newly-added scopes on a fresh authorization, so
existing connections must reconnect. No migration needed: the block's
credential selector already computes `requiredScopes` from
`getScopesForService('microsoft-excel')`, so those connections now show
as needing an update on their own.
The shared `Files.*` labels name OneDrive, which reads as the wrong
product on the Excel consent screen, so add Excel-specific wording
alongside the Word overrides that solve the same problem.1 parent 2690348 commit f690e9b
3 files changed
Lines changed: 40 additions & 7 deletions
File tree
- apps
- docs/content/docs
- integrations
- platform/self-hosting
- sim/lib/oauth
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
47 | 50 | | |
48 | 51 | | |
49 | 52 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
252 | 252 | | |
253 | 253 | | |
254 | 254 | | |
255 | | - | |
| 255 | + | |
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
142 | 161 | | |
143 | 162 | | |
144 | 163 | | |
145 | 164 | | |
146 | 165 | | |
147 | 166 | | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
148 | 170 | | |
149 | 171 | | |
150 | 172 | | |
| |||
1031 | 1053 | | |
1032 | 1054 | | |
1033 | 1055 | | |
1034 | | - | |
1035 | | - | |
1036 | | - | |
1037 | | - | |
| 1056 | + | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
1038 | 1060 | | |
| 1061 | + | |
| 1062 | + | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
1039 | 1069 | | |
1040 | 1070 | | |
1041 | 1071 | | |
| |||
0 commit comments