improvement(knowledge): one scoped search shape, page and pool cleanups, admission ahead of the embedding beside the scope reads

Author: waleedlatif1

apps/sim/lib/billing/core/billing-attribution.ts

@@ -742,13 +742,16 @@ export async function resolveBillingAttribution({
 
 /** The organization payer is independent of the person making the request. */
 export async function resolveOrganizationBillingPayer(organizationId: string) {
-  const [owner] = await db
-    .select({ userId: member.userId })
-    .from(member)
-    .where(and(eq(member.organizationId, organizationId), eq(member.role, 'owner')))
-    .limit(1)
+  /** The owner and the subscription are independent reads; neither waits on the other. */
+  const [[owner], payerSubscription] = await Promise.all([
+    db
+      .select({ userId: member.userId })
+      .from(member)
+      .where(and(eq(member.organizationId, organizationId), eq(member.role, 'owner')))
+      .limit(1),
+    getOrganizationSubscription(organizationId, { onError: 'throw' }),
+  ])
   if (!owner) throw new Error('Organization billing owner is unavailable')
-  const payerSubscription = await getOrganizationSubscription(organizationId, { onError: 'throw' })
   if (payerSubscription && payerSubscription.referenceId !== organizationId)
     throw new Error('Organization subscription belongs to a different payer')
   return { organizationId, billedAccountUserId: owner.userId, payerSubscription }

apps/sim/lib/knowledge/access/availability.ts

@@ -64,7 +64,10 @@ export async function resolveKnowledgeAccessAvailability(
     throw new Error('Knowledge access requires one resource owner')
   /** A caller that brings its own billing snapshot is answered from that snapshot, uncached. */
   if (context.ownerBilling) return readKnowledgeAccessAvailability(context)
-  const key = `${context.organizationId ?? ''}|${context.workspaceId ?? ''}|${context.userId ?? ''}`
+  /** An organization's answer depends on the organization alone; a workspace's on its viewer too. */
+  const key = context.organizationId
+    ? `${context.organizationId}||`
+    : `|${context.workspaceId ?? ''}|${context.userId ?? ''}`
   const availability = await availabilityCache.fetch(key, { context })
   if (!availability) throw new Error('Knowledge access availability could not be resolved')
   return availability
@@ -89,14 +92,14 @@ async function readKnowledgeAccessAvailability(
     return { sourceMirrored: false, memberScoped: false }
   }
   if (context.organizationId) {
-    return {
-      sourceMirrored:
-        !isHosted || (await isOrganizationOnEnterprisePlan(context.organizationId, 'throw')),
-      memberScoped: await isScopedCredentialGroupsAvailable({
+    const [enterprise, memberScoped] = await Promise.all([
+      isHosted ? isOrganizationOnEnterprisePlan(context.organizationId, 'throw') : true,
+      isScopedCredentialGroupsAvailable({
         kind: 'organization',
         organizationId: context.organizationId,
       }),
-    }
+    ])
+    return { sourceMirrored: enterprise, memberScoped }
   }
   if (!context.workspaceId) throw new Error('Knowledge access requires a resource owner')
   const ownerBilling =