Skip to content

Commit ef993ec

Browse files
Bill LeoutsakosBill Leoutsakos
authored andcommitted
fix(ui): preserve icon action parity and address review feedback
1 parent 35f4389 commit ef993ec

20 files changed

Lines changed: 77 additions & 40 deletions

File tree

‎apps/sim/app/_styles/globals.css‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1358,10 +1358,6 @@ input[type="search"]::-ms-clear {
13581358
background-color: transparent !important;
13591359
color: var(--text-tertiary) !important;
13601360
}
1361-
1362-
html[data-panel-active-tab] .panel-container [data-tab-button] span {
1363-
color: inherit !important;
1364-
}
13651361
}
13661362

13671363
/**

‎apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/mic-button/mic-button.tsx‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,17 @@ export const MicButton = memo(function MicButton({
8989
<Tooltip.Trigger asChild>
9090
<Button
9191
type='button'
92-
variant={isListening ? 'active' : 'quiet'}
92+
variant={isListening ? 'active' : 'ghost'}
9393
iconSize='regular'
9494
shape='round'
9595
onClick={onToggle}
9696
aria-label={isListening ? 'Stop listening' : 'Voice input'}
9797
aria-pressed={isListening}
98-
className='relative overflow-hidden transition-[background-color,color,scale] duration-150 ease-out active:scale-[0.96] motion-reduce:transition-none motion-reduce:active:scale-100'
98+
className={cn(
99+
'relative overflow-hidden transition-[background-color,color,scale] duration-150 ease-out active:scale-[0.96] motion-reduce:transition-none motion-reduce:active:scale-100',
100+
!isListening &&
101+
'text-[var(--text-icon)] hover-hover:bg-[var(--surface-hover)] hover-hover:text-[var(--text-icon)]'
102+
)}
99103
>
100104
<span
101105
className={cn(

‎apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/components/document-tags-modal/document-tags-modal.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ export function DocumentTagsModal({
391391
typeLabel={FIELD_TYPE_LABELS[tag.fieldType] || tag.fieldType}
392392
detail={formatValueForDisplay(tag.value, tag.fieldType)}
393393
truncateDetail
394-
removeLabel='Remove tag'
394+
removeLabel={`Remove ${tag.displayName}`}
395395
onRemove={(e) => {
396396
e.stopPropagation()
397397
handleRemoveTag(index)

‎apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/base-tags-modal/base-tags-modal.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ export function BaseTagsModal({ open, onOpenChange, knowledgeBaseId }: BaseTagsM
280280
{usage.documentCount} document{usage.documentCount !== 1 ? 's' : ''}
281281
</>
282282
}
283-
removeLabel='Delete Tag'
283+
removeLabel={`Delete ${tag.displayName}`}
284284
onRemove={(e) => {
285285
e.stopPropagation()
286286
handleDeleteTagClick(tag)

‎apps/sim/app/workspace/[workspaceId]/knowledge/components/knowledge-tag-row.test.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe('KnowledgeTagRow actions', () => {
2828
typeLabel='Text'
2929
detail='3 documents'
3030
activateLabel='View documents for Customer'
31-
removeLabel='Delete tag'
31+
removeLabel='Delete Customer'
3232
onActivate={onActivate}
3333
onRemove={onRemove}
3434
/>
@@ -40,6 +40,7 @@ describe('KnowledgeTagRow actions', () => {
4040
expect(buttons[0].contains(buttons[1])).toBe(false)
4141
expect(buttons[0].getAttribute('type')).toBe('button')
4242
expect(buttons[0].getAttribute('aria-label')).toBe('View documents for Customer')
43+
expect(buttons[1].getAttribute('aria-label')).toBe('Delete Customer')
4344

4445
act(() => buttons[0].click())
4546
expect(onActivate).toHaveBeenCalledTimes(1)

‎apps/sim/app/workspace/[workspaceId]/logs/components/log-details/components/file-download/file-download.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ function FileCard({ file, isExecutionFile = false, workspaceId }: FileCardProps)
106106
{file.type}
107107
{file.version === undefined ? '' : ` · v${file.version}`}
108108
</span>
109-
<Button variant='ghost' size='inline' onClick={handleDownload}>
109+
<Button variant='ghost' size='inline' onClick={handleDownload} className='text-xs'>
110110
<Download className='mr-1 size-[10px]' />
111111
Download
112112
</Button>

‎apps/sim/app/workspace/[workspaceId]/settings/components/admin/admin.tsx‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -443,8 +443,9 @@ export function Admin() {
443443
Page {currentPage} of {totalPages} ({usersData.total} users)
444444
</span>
445445
<div className='flex gap-1'>
446-
<Chip
447-
variant='border-shadow'
446+
<Button
447+
variant='active'
448+
className='h-[28px] text-caption'
448449
onClick={() =>
449450
setAdminParams((prev) => ({
450451
offset: Math.max(0, prev.offset - PAGE_SIZE),
@@ -453,16 +454,17 @@ export function Admin() {
453454
disabled={usersOffset === 0 || usersLoading}
454455
>
455456
Previous
456-
</Chip>
457-
<Chip
458-
variant='border-shadow'
457+
</Button>
458+
<Button
459+
variant='active'
460+
className='h-[28px] text-caption'
459461
onClick={() =>
460462
setAdminParams((prev) => ({ offset: prev.offset + PAGE_SIZE }))
461463
}
462464
disabled={usersOffset + PAGE_SIZE >= (usersData?.total ?? 0) || usersLoading}
463465
>
464466
Next
465-
</Chip>
467+
</Button>
466468
</div>
467469
</div>
468470
)}

‎apps/sim/app/workspace/[workspaceId]/settings/components/mcp/components/mcp-server-form-modal/mcp-server-form-modal.tsx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -763,8 +763,7 @@ export function McpServerFormModal({
763763
type='button'
764764
variant='ghost'
765765
onClick={() => setShowAdvanced((v) => !v)}
766-
size='inline'
767-
className='gap-1 self-start'
766+
className='gap-1 self-start py-0 text-small'
768767
>
769768
{showAdvanced ? (
770769
<ChevronDown className='size-[14px]' />

‎apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-primitives.tsx‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,11 @@ export const AddRowButton = React.memo(function AddRowButton({
7272
<Button
7373
type='button'
7474
variant='ghost'
75-
size='inline'
76-
className={cn('gap-2', blockedReason && 'cursor-not-allowed opacity-50')}
75+
size='sm'
76+
className={cn(
77+
'h-[20px] gap-2 p-0 text-[var(--text-body)]',
78+
blockedReason && 'cursor-not-allowed opacity-50'
79+
)}
7780
aria-disabled={blockedReason ? true : undefined}
7881
onClick={blockedReason ? undefined : onClick}
7982
>

‎apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/grouped-checkbox-list/grouped-checkbox-list.tsx‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,10 @@ export function GroupedCheckboxList({
9797
const noneSelected = selectedValues.length === 0
9898

9999
useEffect(() => {
100-
if (activeSearchTarget?.subBlockId === subBlockId) {
100+
if (!isPreview && activeSearchTarget?.subBlockId === subBlockId) {
101101
setOpen(true)
102102
}
103-
}, [activeSearchTarget, subBlockId])
103+
}, [activeSearchTarget, isPreview, subBlockId])
104104

105105
useEffect(() => {
106106
if (!open || activeSearchTarget?.subBlockId !== subBlockId) return
@@ -119,7 +119,8 @@ export function GroupedCheckboxList({
119119
leftAdornment={
120120
<ManageWorkspace className='size-4 shrink-0 opacity-50' data-preview-full-opacity />
121121
}
122-
disabled={disabled}
122+
disabled={disabled || isPreview}
123+
data-preview-full-opacity={isPreview || undefined}
123124
onClick={() => setOpen(true)}
124125
rightAdornment={
125126
<SelectedCountDisplay
@@ -131,7 +132,12 @@ export function GroupedCheckboxList({
131132
>
132133
Configure PII Types
133134
</Chip>
134-
<ChipModal open={open} onOpenChange={setOpen} srTitle='Select PII Types to Detect' size='lg'>
135+
<ChipModal
136+
open={open && !isPreview}
137+
onOpenChange={setOpen}
138+
srTitle='Select PII Types to Detect'
139+
size='lg'
140+
>
135141
<ChipModalHeader onClose={() => setOpen(false)}>Select PII Types to Detect</ChipModalHeader>
136142
<ChipModalBody onWheel={(e) => e.stopPropagation()}>
137143
<ChipModalField

0 commit comments

Comments
 (0)