Skip to content

Commit e2ae0af

Browse files
committed
chore(knowledge): sync review fixes with staging
2 parents 34ad25e + 1829feb commit e2ae0af

3 files changed

Lines changed: 345 additions & 4 deletions

File tree

  • apps/sim
    • app/o/[organizationId]/settings/integrations/sources/[connectorId]
    • content/library/ai-native-workflow-automation-vs-traditional-automation
    • public/library/ai-native-workflow-automation-vs-traditional-automation

‎apps/sim/app/o/[organizationId]/settings/integrations/sources/[connectorId]/source-detail.test.tsx‎

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -293,20 +293,28 @@ describe('organization source detail navigation', () => {
293293
)
294294

295295
it.each(['active', 'pending', 'syncing'] as const)(
296-
'preserves the permission warning among composed notices while %s',
296+
'keeps permission warnings visible alongside other sync notices while %s',
297297
async (status) => {
298298
mocks.detail.mockReturnValue({
299299
data: {
300300
...connector,
301+
accessMode: 'admin',
301302
status,
302-
lastSyncError: `Directory refresh incomplete: private details\n${SOURCE_PERMISSION_ERROR}\nSource listing failed for a private account`,
303+
lastSyncError: [
304+
'Directory refresh incomplete: Private directory details',
305+
'Source listing failed for 1 account. Private account details',
306+
SOURCE_PERMISSION_ERROR,
307+
].join('\n'),
303308
},
304309
})
305310
await render()
306311
expect(container.textContent).toContain('Permission verification incomplete')
307312
expect(container.textContent).toContain(SOURCE_PERMISSION_ERROR)
308-
expect(container.textContent).not.toContain('private')
309-
expect(container.textContent).not.toContain('Review the connection settings')
313+
expect(container.textContent).not.toContain('Private directory details')
314+
expect(container.textContent).not.toContain('Private account details')
315+
expect(container.textContent).not.toContain(
316+
'Review the connection settings and try syncing again.'
317+
)
310318
}
311319
)
312320

0 commit comments

Comments
 (0)