Commit d7388c6
committed
fix(files): import the folder picker from the components barrel
CI's Lint and Test failed on sub-block-password.test.tsx, a test this branch
does not touch, with a missing icon export from a partial mock.
The cause was a deep import. sub-block.tsx takes every other subblock component
from the components barrel, and that test mocks the barrel wholesale — which is
what keeps the editor's module graph out of its way. My folder picker was
imported directly from its file instead, bypassing the mock and pulling the real
chain in behind it: use-resource-folders, the realtime invalidation room, the
socket provider, the workflow stores, and through them the block and trigger
registries. Every trigger's icon then had to appear in that test's icon mock.
Exporting the picker from the barrel and importing it from there fixes it with
no change to the test, which is the sign it was the right fix — I had first
patched the mock, then stubbed the socket provider, and both were treating a
symptom. The repo's import rules already say to use the barrel; I had not.1 parent 0878ae6 commit d7388c6
2 files changed
Lines changed: 2 additions & 1 deletion
File tree
- apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block
- components
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
| |||
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
55 | | - | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
0 commit comments