improvement(credentials): allow connecting accounts with different emails

Author: TheodoreSpeaks

apps/sim/app/api/credential-groups/oauth-callback.test.ts

@@ -65,8 +65,8 @@ describe('GitHub managed OAuth failure presentation', () => {
   describe.each([false, true])('completion redirect: %s', (completionRedirect) => {
     it.each([
       {
-        failure: new OAuthIdentityVerificationError('email_mismatch', 'emails'),
-        status: 'github_email_mismatch',
+        failure: new OAuthIdentityVerificationError('email_unverified', 'emails'),
+        status: 'github_email_unverified',
       },
       {
         failure: new OAuthIdentityVerificationError('email_access_denied', 'emails', 403),

apps/sim/app/api/credential-groups/oauth-callback.ts

@@ -112,16 +112,14 @@ export async function handleCredentialGroupOAuthCallback({
       error instanceof CredentialGroupInvitationUnavailableError
         ? 'unavailable'
         : error instanceof CredentialGroupOAuthError && error.statusCode === 403
-          ? error.message.startsWith('Sign in with')
-            ? 'account_mismatch'
-            : 'permissions_required'
+          ? 'permissions_required'
           : error instanceof CredentialGroupOAuthError && error.statusCode === 409
             ? 'configuration_changed'
             : 'failed'
     if (identityFailure) {
       switch (identityFailure.reason) {
-        case 'email_mismatch':
-          status = provider === 'github-repositories' ? 'github_email_mismatch' : 'account_mismatch'
+        case 'email_unverified':
+          status = provider === 'github-repositories' ? 'github_email_unverified' : 'failed'
           break
         case 'email_access_denied':
           status =

apps/sim/app/api/credential-groups/oauth/[provider]/callback/route.test.ts

@@ -115,7 +115,6 @@ describe('credential group OAuth callback', () => {
 
   it.each([
     [new CredentialGroupInvitationUnavailableError(), 'unavailable'],
-    [new CredentialGroupOAuthError('Sign in with your own account', 403), 'account_mismatch'],
     [new CredentialGroupOAuthError('Missing scopes', 403), 'permissions_required'],
     [new CredentialGroupOAuthError('Changed settings', 409), 'configuration_changed'],
     [new Error('Provider failed'), 'failed'],
@@ -250,7 +249,6 @@ describe('credential group OAuth callback', () => {
 
   it.each([
     [new CredentialGroupInvitationUnavailableError(), 'unavailable'],
-    [new CredentialGroupOAuthError('Sign in with your own account', 403), 'account_mismatch'],
     [new CredentialGroupOAuthError('Missing scopes', 403), 'permissions_required'],
     [new CredentialGroupOAuthError('Changed settings', 409), 'configuration_changed'],
     [new Error('Provider failed'), 'failed'],

apps/sim/app/credential-groups/enroll/[token]/page.test.tsx

@@ -307,7 +307,7 @@ describe('focused Search enrollment', () => {
   })
 
   it.each([
-    ['github_email_mismatch', 'add and verify the email address'],
+    ['github_email_unverified', 'verify your primary email address'],
     ['github_email_access_denied', 'Email addresses: Read-only permission'],
     ['provider_unavailable', 'Try connecting again in a few minutes'],
   ])(

apps/sim/app/credential-groups/enroll/[token]/page.tsx

@@ -110,7 +110,6 @@ function UnavailableSearchConnection({
 const OAUTH_MESSAGES = {
   ...CREDENTIAL_GROUP_OAUTH_FAILURE_MESSAGES,
   denied: 'Authorization was canceled. Nothing was connected.',
-  account_mismatch: 'Choose the account matching the email address on this invitation.',
   permissions_required: 'All requested permissions are required to connect this account.',
   configuration_changed: 'This credential option changed. Reload the page and try again.',
   unavailable: 'Account authorization is temporarily unavailable. Please try again.',

apps/sim/hooks/use-member-enrollment.test.tsx

@@ -122,7 +122,7 @@ afterEach(() => {
 })
 
 describe('useMemberEnrollment', () => {
-  it('reports an OAuth mismatch once per attempt and allows the same error on a later retry', () => {
+  it('reports an OAuth failure once per attempt and allows the same error on a later retry', () => {
     mount(new Set(), true, mocks.connectionError)
     for (let index = 0; index < 2; index += 1) {
       act(() => enrollment().connect('kb-1', 'connector-1'))
@@ -132,16 +132,20 @@ describe('useMemberEnrollment', () => {
         })
       )
       act(() =>
-        mocks.channels[index].onmessage?.(new MessageEvent('message', { data: 'account_mismatch' }))
+        mocks.channels[index].onmessage?.(
+          new MessageEvent('message', { data: 'permissions_required' })
+        )
       )
       act(() =>
-        mocks.channels[index].onmessage?.(new MessageEvent('message', { data: 'account_mismatch' }))
+        mocks.channels[index].onmessage?.(
+          new MessageEvent('message', { data: 'permissions_required' })
+        )
       )
       expect(mocks.connectionError).toHaveBeenCalledTimes(index + 1)
       expect(enrollment().isAwaiting('connector-1')).toBe(false)
     }
     expect(mocks.connectionError).toHaveBeenLastCalledWith(
-      'Choose the account matching your Sim email address.'
+      'All requested permissions are required to connect this account.'
     )
     act(() => vi.advanceTimersByTime(10 * 60_000))
     expect(mocks.connectionError).toHaveBeenCalledTimes(2)
@@ -179,7 +183,7 @@ describe('useMemberEnrollment', () => {
       act(() => mocks.channels[1].onmessage?.(new MessageEvent('message', { data: 'connected' })))
       act(() => vi.advanceTimersByTime(10 * 60_000))
       act(() =>
-        mocks.channels[0].onmessage?.(new MessageEvent('message', { data: 'account_mismatch' }))
+        mocks.channels[0].onmessage?.(new MessageEvent('message', { data: 'permissions_required' }))
       )
       expect(mocks.connectionError).not.toHaveBeenCalled()
       expect(enrollment().error).toBeNull()
@@ -211,10 +215,10 @@ describe('useMemberEnrollment', () => {
   })
 
   it.each([
-    ['existing', 'account_mismatch'],
+    ['existing', 'permissions_required'],
     ['existing', 'denied'],
     ['existing', 'expired'],
-    ['new', 'account_mismatch'],
+    ['new', 'permissions_required'],
     ['new', 'denied'],
     ['new', 'expired'],
   ] as const)(

apps/sim/hooks/use-personal-source-account.test.tsx

@@ -108,10 +108,12 @@ describe('personal source account authorization', () => {
     act(() => root.render(<Probe />))
     expect(current.pending).toBe(false)
   })
-  it('shows an account mismatch as a toast and allows a fresh attempt', async () => {
+  it('shows missing permissions as a toast and allows a fresh attempt', async () => {
     await act(async () => current.connect())
-    act(() => channels[0].onmessage?.({ data: 'account_mismatch' } as MessageEvent<unknown>))
-    expect(mocks.error).toHaveBeenCalledWith('Choose the account matching your Sim email address.')
+    act(() => channels[0].onmessage?.({ data: 'permissions_required' } as MessageEvent<unknown>))
+    expect(mocks.error).toHaveBeenCalledWith(
+      'All requested permissions are required to connect this account.'
+    )
     expect(current.pending).toBe(false)
     await act(async () => current.connect())
     expect(mocks.authorize).toHaveBeenCalledTimes(2)

apps/sim/lib/auth/connectors/managed-oauth.test.ts

@@ -45,7 +45,6 @@ describe('Atlassian managed OAuth connector', () => {
       requiresRefreshToken: true,
       pkce: false,
       nonceVerification: 'state_only',
-      includeLoginHint: false,
       authorizationUrlParams: { audience: 'api.atlassian.com' },
     })
     expect(fetchMock).toHaveBeenCalledWith(
@@ -490,7 +489,6 @@ describe('Microsoft managed OAuth connector', () => {
           requiresRefreshToken: true,
           pkce: true,
           nonceVerification: 'id_token',
-          includeLoginHint: true,
           prompt: 'select_account',
         })
         return policy.getAuthorizationAppId(CLIENT_ID)

apps/sim/lib/auth/connectors/managed-oauth.ts

@@ -62,14 +62,12 @@ export interface ManagedOAuthConnectorConfig {
    */
   scopeless?: boolean
   nonceVerification: 'id_token' | 'state_only'
-  includeLoginHint: boolean
   prompt?: string
   authorizationUrlParams?: Record<string, string>
   getAuthorizationAppId(clientId: string): string
   verifyIdentity(params: {
     tokens: OAuth2Tokens
     clientId: string
-    expectedEmail?: string
   }): Promise<ManagedOAuthConnectorIdentity>
   hasRequiredScopes(grantedScopes: string[], requiredScopes: string[]): boolean
   isTerminalRefreshError(errorCode: string | undefined): boolean
@@ -120,7 +118,6 @@ export function createGoogleManagedOAuthConnector(providerId: string): ManagedOA
     requiresRefreshToken: true,
     pkce: true,
     nonceVerification: 'id_token',
-    includeLoginHint: true,
     prompt: 'consent select_account',
     authorizationUrlParams: { include_granted_scopes: 'false' },
     getAuthorizationAppId(clientId) {
@@ -199,7 +196,6 @@ export function createAtlassianManagedOAuthConnector(
     requiresRefreshToken: true,
     pkce: false,
     nonceVerification: 'state_only',
-    includeLoginHint: false,
     prompt: 'consent',
     authorizationUrlParams: { audience: 'api.atlassian.com' },
     getAuthorizationAppId(clientId) {
@@ -350,7 +346,6 @@ export function createMicrosoftManagedOAuthConnector(
     requiresRefreshToken: true,
     pkce: true,
     nonceVerification: 'id_token',
-    includeLoginHint: true,
     prompt: 'select_account',
     getAuthorizationAppId(clientId) {
       return `microsoft:${createHash('sha256').update(clientId).digest('hex')}`
@@ -521,7 +516,6 @@ export function createUserInfoManagedOAuthConnector(
     requiresRefreshToken: options.requiresRefreshToken,
     pkce: options.pkce ?? false,
     nonceVerification: 'state_only',
-    includeLoginHint: false,
     ...(options.scopeless ? { scopeless: true } : {}),
     ...(options.prompt ? { prompt: options.prompt } : {}),
     ...(options.authorizationUrlParams
@@ -659,7 +653,6 @@ function createAttioManagedOAuthConnector(): ManagedOAuthConnectorConfig {
     requiresRefreshToken: false,
     pkce: false,
     nonceVerification: 'state_only',
-    includeLoginHint: false,
     getAuthorizationAppId(clientId) {
       return `attio:${createHash('sha256').update(clientId).digest('hex')}`
     },
@@ -745,7 +738,6 @@ function createBitbucketManagedOAuthConnector(): ManagedOAuthConnectorConfig {
     requiresRefreshToken: true,
     pkce: false,
     nonceVerification: 'state_only',
-    includeLoginHint: false,
     getAuthorizationAppId(clientId) {
       return `bitbucket:${createHash('sha256').update(clientId).digest('hex')}`
     },
@@ -985,12 +977,11 @@ const USER_INFO_MANAGED_OAUTH_CONNECTORS = new Map<string, () => ManagedOAuthCon
       pkce: true,
       scopeless: true,
       nonceVerification: 'state_only',
-      includeLoginHint: false,
       getAuthorizationAppId(clientId) {
         return `github-repositories:${createHash('sha256').update(clientId).digest('hex')}`
       },
-      verifyIdentity({ tokens, expectedEmail }) {
-        return verifyGitHubRepositoriesIdentity(tokens.accessToken ?? '', expectedEmail)
+      verifyIdentity({ tokens }) {
+        return verifyGitHubRepositoriesIdentity(tokens.accessToken ?? '')
       },
       hasRequiredScopes(_grantedScopes, requiredScopes) {
         return requiredScopes.length === 0

apps/sim/lib/credential-groups/README.md

@@ -10,7 +10,7 @@ Both pages include **People → Request connections**, with the existing manual
 
 An allowed workspace grants every normally authorized manual and deployed workflow access to every active contribution in this pool. There is no per-workflow resource-policy grant and no per-person filtering for workflow execution. Keep ordinary workspace/workflow authorization and deployment authority: an allowlist entry alone cannot authorize running a workflow. Nested workflows use their actual execution workspace. A workspace move, revocation, inactive enrollment, removed provider, disabled group, or unavailable org entitlement blocks subsequent use.
 
-Standalone Chat uses the signed-in person’s own connections. Invited contributors do not need organization membership. Redemption requires a verified matching Sim email; the enrollment is then bound permanently to that user ID. An email change cannot transfer an enrollment. OAuth callbacks require the same verified signed-in user who started authorization. Search requires current organization membership and applies document permissions using the viewer's own verified provider identities; workspace access to the shared credential pool does not grant access to other people's indexed documents.
+Standalone Chat uses the signed-in person’s own connections. Invited contributors do not need organization membership. Redemption requires a verified Sim email matching the invitation; the enrollment is then bound permanently to that user ID. An email change cannot transfer an enrollment. People can connect any provider account they can authorize, even when its email differs from their Sim or invitation email. OAuth callbacks require the same verified signed-in user who started authorization. Search requires current organization membership and applies document permissions using the viewer's own verified provider identities; workspace access to the shared credential pool does not grant access to other people's indexed documents.
 
 Disconnect revokes the local grant and invalidates pending invitation-based authorization. Administrators can revoke an enrollment; the person cannot restore it themselves. Removing workspace access stops future authorized calls, but cannot recall a provider request already in flight or erase data already returned to a workflow. Full-pool sharing includes public, scheduled, and webhook deployments that otherwise pass workflow authorization.