Address PR review feedback (#5615)

- Reject chat uploads that belong to another workspace
- Add regression coverage for media upload ownership

Author: j15z

apps/sim/lib/copilot/tools/server/media/file-paths.test.ts

@@ -28,7 +28,7 @@ import {
   validateMediaOutputFile,
 } from '@/lib/copilot/tools/server/media/file-paths'
 
-const FILE_RECORD = { id: 'wf_file', name: 'portrait.png' }
+const FILE_RECORD = { id: 'wf_file', name: 'portrait.png', workspaceId: 'workspace-1' }
 
 describe('media file paths', () => {
   beforeEach(() => {
@@ -65,6 +65,20 @@ describe('media file paths', () => {
     expect(mocks.resolveChatUpload).toHaveBeenCalledWith('My%20Portrait.png', 'chat-1')
   })
 
+  it('rejects uploads from a different workspace', async () => {
+    mocks.resolveChatUpload.mockResolvedValue({ ...FILE_RECORD, workspaceId: 'workspace-2' })
+
+    await expect(
+      resolveMediaInputFile({
+        workspaceId: 'workspace-1',
+        chatId: 'chat-1',
+        path: 'uploads/My%20Portrait.png',
+      })
+    ).rejects.toThrow(
+      'Upload does not belong to the current workspace: "uploads/My%20Portrait.png"'
+    )
+  })
+
   it('rejects unresolved inputs instead of dropping them', async () => {
     mocks.resolveWorkspaceFileReference.mockResolvedValue(null)
 

apps/sim/lib/copilot/tools/server/media/file-paths.ts

@@ -57,6 +57,9 @@ export async function resolveMediaInputFile(args: {
       throw new Error(`Chat context is required for upload input: ${path}`)
     }
     file = await resolveChatUpload(filename, args.chatId)
+    if (file && file.workspaceId !== args.workspaceId) {
+      throw new Error(`Upload does not belong to the current workspace: "${path}"`)
+    }
   } else {
     file = await resolveWorkspaceFileReference(args.workspaceId, path)
   }

apps/sim/lib/copilot/tools/server/media/media-tools-validation.test.ts

@@ -38,6 +38,7 @@ const UPLOAD_RECORD = {
   id: 'wf_upload',
   name: 'start.png',
   type: 'image/png',
+  workspaceId: 'workspace-1',
   storageContext: 'mothership',
 }