test(table): share one table-definition fixture factory

buildTable was copy-pasted into 13 route test files under app/api/table, each
a near-identical TableDefinition literal. A required field added to that type
would have failed 13 files individually.

packages/testing already owned createTableColumn and createTableRow but no
definition factory, and — as it turns out — did not export any of them from
the barrel, so they were unreachable from @sim/testing. Adds
createTableDefinition beside them and exports all three.

The fixture type is a structural stand-in rather than TableDefinition itself,
because packages/* must not import from apps/* — the same approach the
existing factories in that file already take.

No assertion changed. Call sites that varied a field pass it as an override;
the four files with several call sites hoist a shared options const and spread
it so each call still gets a fresh object.

Author: waleedlatif1

apps/sim/app/api/table/[tableId]/delete-async/route.test.ts

@@ -1,10 +1,15 @@
 /**
  * @vitest-environment node
  */
-import { hybridAuthMockFns, resetEnvFlagsMock, setEnvFlags } from '@sim/testing'
+import {
+  createTableDefinition,
+  hybridAuthMockFns,
+  resetEnvFlagsMock,
+  setEnvFlags,
+  type TableDefinitionFactoryOptions,
+} from '@sim/testing'
 import { NextRequest, NextResponse } from 'next/server'
 import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
-import type { TableDefinition } from '@/lib/table'
 
 const {
   mockCheckAccess,
@@ -58,22 +63,9 @@ import { POST } from '@/app/api/table/[tableId]/delete-async/route'
 
 afterAll(resetEnvFlagsMock)
 
-function buildTable(overrides: Partial<TableDefinition> = {}): TableDefinition {
-  return {
-    id: 'tbl_1',
-    name: 'People',
-    description: null,
-    schema: { columns: [{ name: 'status', type: 'string' }] },
-    metadata: null,
-    rowCount: 1000,
-    maxRows: 1_000_000,
-    workspaceId: 'workspace-1',
-    createdBy: 'user-1',
-    archivedAt: null,
-    createdAt: new Date(),
-    updatedAt: new Date(),
-    ...overrides,
-  }
+const TABLE_FIXTURE: TableDefinitionFactoryOptions = {
+  columns: [{ name: 'status', type: 'string' }],
+  rowCount: 1000,
 }
 
 function makeRequest(body: unknown, tableId = 'tbl_1') {
@@ -99,7 +91,7 @@ describe('POST /api/table/[tableId]/delete-async', () => {
       userId: 'user-1',
       authType: 'session',
     })
-    mockCheckAccess.mockResolvedValue({ ok: true, table: buildTable() })
+    mockCheckAccess.mockResolvedValue({ ok: true, table: createTableDefinition(TABLE_FIXTURE) })
     mockMarkTableJobRunning.mockResolvedValue(true)
     mockRunTableDelete.mockResolvedValue(undefined)
     mockTableFilterError.mockReturnValue(null)
@@ -168,7 +160,10 @@ describe('POST /api/table/[tableId]/delete-async', () => {
   })
 
   it('returns 400 when the table is archived', async () => {
-    mockCheckAccess.mockResolvedValue({ ok: true, table: buildTable({ archivedAt: new Date() }) })
+    mockCheckAccess.mockResolvedValue({
+      ok: true,
+      table: createTableDefinition({ ...TABLE_FIXTURE, archivedAt: new Date() }),
+    })
     const response = await makeRequest(validBody)
     expect(response.status).toBe(400)
     expect(mockRunTableDelete).not.toHaveBeenCalled()

apps/sim/app/api/table/[tableId]/dispatches/route.test.ts

@@ -1,10 +1,9 @@
 /**
  * @vitest-environment node
  */
-import { hybridAuthMockFns } from '@sim/testing'
+import { createTableDefinition, hybridAuthMockFns } from '@sim/testing'
 import { NextRequest } from 'next/server'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
-import type { TableDefinition } from '@/lib/table'
 
 const { mockCheckAccess, mockListActiveDispatches, mockCountRunningCells } = vi.hoisted(() => ({
   mockCheckAccess: vi.fn(),
@@ -27,24 +26,6 @@ vi.mock('@/app/api/table/utils', async () => {
 
 import { GET } from '@/app/api/table/[tableId]/dispatches/route'
 
-function buildTable(overrides: Partial<TableDefinition> = {}): TableDefinition {
-  return {
-    id: 'tbl_1',
-    name: 'People',
-    description: null,
-    schema: { columns: [] },
-    metadata: null,
-    rowCount: 0,
-    maxRows: 1_000_000,
-    workspaceId: 'workspace-1',
-    createdBy: 'user-1',
-    archivedAt: null,
-    createdAt: new Date(),
-    updatedAt: new Date(),
-    ...overrides,
-  }
-}
-
 function makeRequest(tableId = 'tbl_1') {
   const req = new NextRequest(`http://localhost:3000/api/table/${tableId}/dispatches`)
   return GET(req, { params: Promise.resolve({ tableId }) })
@@ -75,7 +56,7 @@ describe('GET /api/table/[tableId]/dispatches', () => {
       userId: 'user-1',
       authType: 'session',
     })
-    mockCheckAccess.mockResolvedValue({ ok: true, table: buildTable() })
+    mockCheckAccess.mockResolvedValue({ ok: true, table: createTableDefinition() })
     mockListActiveDispatches.mockResolvedValue([])
     mockCountRunningCells.mockResolvedValue({ byRowId: {}, hasRunning: false })
   })

apps/sim/app/api/table/[tableId]/export-async/route.test.ts

@@ -1,10 +1,9 @@
 /**
  * @vitest-environment node
  */
-import { hybridAuthMockFns } from '@sim/testing'
+import { createTableDefinition, hybridAuthMockFns } from '@sim/testing'
 import { NextRequest } from 'next/server'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
-import type { TableDefinition } from '@/lib/table'
 
 const { mockCheckAccess, mockMarkTableJobRunning, mockRunTableExport } = vi.hoisted(() => ({
   mockCheckAccess: vi.fn(),
@@ -34,24 +33,6 @@ vi.mock('@/app/api/table/utils', async () => {
 
 import { POST } from '@/app/api/table/[tableId]/export-async/route'
 
-function buildTable(overrides: Partial<TableDefinition> = {}): TableDefinition {
-  return {
-    id: 'tbl_1',
-    name: 'People',
-    description: null,
-    schema: { columns: [{ name: 'name', type: 'string' }] },
-    metadata: null,
-    rowCount: 50000,
-    maxRows: 1_000_000,
-    workspaceId: 'workspace-1',
-    createdBy: 'user-1',
-    archivedAt: null,
-    createdAt: new Date(),
-    updatedAt: new Date(),
-    ...overrides,
-  }
-}
-
 function makeRequest(body: unknown, tableId = 'tbl_1') {
   const req = new NextRequest(`http://localhost:3000/api/table/${tableId}/export-async`, {
     method: 'POST',
@@ -71,7 +52,13 @@ describe('POST /api/table/[tableId]/export-async', () => {
       userId: 'user-1',
       authType: 'session',
     })
-    mockCheckAccess.mockResolvedValue({ ok: true, table: buildTable() })
+    mockCheckAccess.mockResolvedValue({
+      ok: true,
+      table: createTableDefinition({
+        columns: [{ name: 'name', type: 'string' }],
+        rowCount: 50000,
+      }),
+    })
     mockMarkTableJobRunning.mockResolvedValue(true)
     mockRunTableExport.mockResolvedValue(undefined)
   })

apps/sim/app/api/table/[tableId]/export/download/route.test.ts

@@ -1,10 +1,9 @@
 /**
  * @vitest-environment node
  */
-import { hybridAuthMockFns } from '@sim/testing'
+import { createTableDefinition, hybridAuthMockFns } from '@sim/testing'
 import { NextRequest } from 'next/server'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
-import type { TableDefinition } from '@/lib/table'
 
 const { mockCheckAccess, mockGetTableJob, mockGeneratePresignedDownloadUrl } = vi.hoisted(() => ({
   mockCheckAccess: vi.fn(),
@@ -27,24 +26,6 @@ vi.mock('@/app/api/table/utils', async () => {
 
 import { GET } from '@/app/api/table/[tableId]/export/download/route'
 
-function buildTable(overrides: Partial<TableDefinition> = {}): TableDefinition {
-  return {
-    id: 'tbl_1',
-    name: 'People',
-    description: null,
-    schema: { columns: [] },
-    metadata: null,
-    rowCount: 0,
-    maxRows: 1_000_000,
-    workspaceId: 'workspace-1',
-    createdBy: 'user-1',
-    archivedAt: null,
-    createdAt: new Date(),
-    updatedAt: new Date(),
-    ...overrides,
-  }
-}
-
 function makeRequest(query: Record<string, string>, tableId = 'tbl_1') {
   const qs = new URLSearchParams(query).toString()
   const req = new NextRequest(`http://localhost:3000/api/table/${tableId}/export/download?${qs}`)
@@ -61,7 +42,7 @@ describe('GET /api/table/[tableId]/export/download', () => {
       userId: 'user-1',
       authType: 'session',
     })
-    mockCheckAccess.mockResolvedValue({ ok: true, table: buildTable() })
+    mockCheckAccess.mockResolvedValue({ ok: true, table: createTableDefinition() })
     mockGetTableJob.mockResolvedValue({
       id: 'job_1',
       type: 'export',

apps/sim/app/api/table/[tableId]/export/route.test.ts

@@ -1,10 +1,9 @@
 /**
  * @vitest-environment node
  */
-import { hybridAuthMockFns } from '@sim/testing'
+import { createTableDefinition, hybridAuthMockFns } from '@sim/testing'
 import { NextRequest } from 'next/server'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
-import type { TableDefinition } from '@/lib/table'
 
 const { mockCheckAccess, mockQueryRows } = vi.hoisted(() => ({
   mockCheckAccess: vi.fn(),
@@ -27,27 +26,6 @@ vi.mock('@/lib/table/rows/service', () => ({
 import { GET } from '@/app/api/table/[tableId]/export/route'
 
 /** Table with an id-native column whose stable id (`col_email`) differs from its display name. */
-function buildTable(): TableDefinition {
-  return {
-    id: 'tbl_1',
-    name: 'People',
-    description: null,
-    schema: {
-      columns: [
-        { id: 'col_email', name: 'email', type: 'string' },
-        { name: 'legacy', type: 'string' }, // legacy: id == name
-      ],
-    },
-    metadata: null,
-    rowCount: 1,
-    maxRows: 100,
-    workspaceId: 'workspace-1',
-    createdBy: 'user-1',
-    archivedAt: null,
-    createdAt: new Date('2024-01-01'),
-    updatedAt: new Date('2024-01-01'),
-  }
-}
 
 function callGet(format: string) {
   const req = new NextRequest(`http://localhost:3000/api/table/tbl_1/export?format=${format}`, {
@@ -64,7 +42,19 @@ describe('table export route — id→name translation', () => {
       userId: 'user-1',
       authType: 'session',
     })
-    mockCheckAccess.mockResolvedValue({ ok: true, table: buildTable() })
+    mockCheckAccess.mockResolvedValue({
+      ok: true,
+      table: createTableDefinition({
+        columns: [
+          { id: 'col_email', name: 'email', type: 'string' },
+          { name: 'legacy', type: 'string' }, // legacy: id == name
+        ],
+        rowCount: 1,
+        maxRows: 100,
+        createdAt: new Date('2024-01-01'),
+        updatedAt: new Date('2024-01-01'),
+      }),
+    })
     // Row data is keyed by stable column id (`col_email`), not the display name.
     mockQueryRows.mockResolvedValue({
       rows: [{ id: 'r1', data: { col_email: 'a@b.c', legacy: 'x' }, executions: {}, position: 0 }],

apps/sim/app/api/table/[tableId]/import-async/route.test.ts

@@ -1,10 +1,13 @@
 /**
  * @vitest-environment node
  */
-import { hybridAuthMockFns } from '@sim/testing'
+import {
+  createTableDefinition,
+  hybridAuthMockFns,
+  type TableDefinitionFactoryOptions,
+} from '@sim/testing'
 import { NextRequest } from 'next/server'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
-import type { TableDefinition } from '@/lib/table'
 
 const { mockCheckAccess, mockMarkTableImporting, mockRunTableImport } = vi.hoisted(() => ({
   mockCheckAccess: vi.fn(),
@@ -34,22 +37,8 @@ vi.mock('@/app/api/table/utils', async () => {
 
 import { POST } from '@/app/api/table/[tableId]/import-async/route'
 
-function buildTable(overrides: Partial<TableDefinition> = {}): TableDefinition {
-  return {
-    id: 'tbl_1',
-    name: 'People',
-    description: null,
-    schema: { columns: [{ name: 'name', type: 'string' }] },
-    metadata: null,
-    rowCount: 0,
-    maxRows: 1_000_000,
-    workspaceId: 'workspace-1',
-    createdBy: 'user-1',
-    archivedAt: null,
-    createdAt: new Date(),
-    updatedAt: new Date(),
-    ...overrides,
-  }
+const TABLE_FIXTURE: TableDefinitionFactoryOptions = {
+  columns: [{ name: 'name', type: 'string' }],
 }
 
 function makeRequest(body: unknown, tableId = 'tbl_1') {
@@ -76,7 +65,7 @@ describe('POST /api/table/[tableId]/import-async', () => {
       userId: 'user-1',
       authType: 'session',
     })
-    mockCheckAccess.mockResolvedValue({ ok: true, table: buildTable() })
+    mockCheckAccess.mockResolvedValue({ ok: true, table: createTableDefinition(TABLE_FIXTURE) })
     mockMarkTableImporting.mockResolvedValue(true)
     mockRunTableImport.mockResolvedValue(undefined)
   })
@@ -126,7 +115,10 @@ describe('POST /api/table/[tableId]/import-async', () => {
   })
 
   it('returns 400 when the target table is archived', async () => {
-    mockCheckAccess.mockResolvedValue({ ok: true, table: buildTable({ archivedAt: new Date() }) })
+    mockCheckAccess.mockResolvedValue({
+      ok: true,
+      table: createTableDefinition({ ...TABLE_FIXTURE, archivedAt: new Date() }),
+    })
     const response = await makeRequest(validBody)
     expect(response.status).toBe(400)
     expect(mockRunTableImport).not.toHaveBeenCalled()