Run LB OTE tests serially with provider-specific allowlists

Pipe-all run-test parallelizes [lb][Serial] cases and causes Octavia timeouts.
lb_tests now uses Amphora/OVN allowlists and openstack_test_ote_run_serial.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: tusharjadhav3302

collection/stages/roles/lb_tests/defaults/main.yml

@@ -1,4 +1,6 @@
 ---
 # defaults file for lb_tests
 lb_allowlist_file: 'files/openstack-test-lb-allowlist.yaml'
+lb_amphora_allowlist_file: "{{ role_path }}/files/openstack-test-lb-amphora-allowlist.yaml"
+lb_ovn_allowlist_file: "{{ role_path }}/files/openstack-test-lb-ovn-allowlist.yaml"
 lb_blocklist_file: "{{ role_path }}/files/openstack-test-lb-ingress-blocklist.yaml"

collection/stages/roles/lb_tests/files/openstack-test-lb-amphora-allowlist.yaml

@@ -0,0 +1,3 @@
+---
+".*Amphora.*":
+  note: "Amphora Load Balancer tests (lb_tests stage only)"

collection/stages/roles/lb_tests/files/openstack-test-lb-ovn-allowlist.yaml

@@ -0,0 +1,3 @@
+---
+".*OVN.*":
+  note: "OVN Load Balancer tests (lb_tests stage only)"

collection/stages/roles/lb_tests/tasks/main.yml

@@ -1,8 +1,10 @@
 ---
 # include_role(openstack_test) re-templates vars; role_path there is openstack_test, not lb_tests.
-- name: Materialize ingress blocklist path for nested openstack_test role
+- name: Materialize LB allow/block paths for nested openstack_test role
   ansible.builtin.set_fact:
     lb_ingress_blocklist_resolved: "{{ lb_blocklist_file }}"
+    lb_amphora_allowlist_resolved: "{{ lb_amphora_allowlist_file }}"
+    lb_ovn_allowlist_resolved: "{{ lb_ovn_allowlist_file }}"
 
 - name: Get install-config content to obtain the 1st machineCIDR
   ansible.builtin.include_role:
@@ -34,8 +36,9 @@
     name: shiftstack.stages.openstack_test
   vars:
     openstack_test_results_dir: "{{ artifacts_dir }}/lb_amphora_sourceip"
-    openstack_tests_allowlist_file: "{{ lb_allowlist_file }}"
+    openstack_tests_allowlist_file: "{{ lb_amphora_allowlist_resolved }}"
     openstack_tests_blocklist_file: "{{ lb_ingress_blocklist_resolved }}"
+    openstack_test_ote_run_serial: true
     openstack_testsuite_name: openstack_tests_lb_amphora_sourceip
     openstack_reset_result_dir: no # As we want to keep the logs generated in the previous step
 
@@ -53,7 +56,8 @@
     name: shiftstack.stages.openstack_test
   vars:
     openstack_test_results_dir: "{{ artifacts_dir }}/lb_ovn"
-    openstack_tests_allowlist_file: "{{ lb_allowlist_file }}"
+    openstack_tests_allowlist_file: "{{ lb_ovn_allowlist_resolved }}"
     openstack_tests_blocklist_file: "{{ lb_ingress_blocklist_resolved }}"
+    openstack_test_ote_run_serial: true
     openstack_testsuite_name: openstack_tests_lb_ovn
     openstack_reset_result_dir: no # As we want to keep the logs generated in the previous step

collection/stages/roles/openstack_test/defaults/main.yml

@@ -12,3 +12,5 @@ openstack_tests_go_version: "{{ tests.default_go_version_target }}"
 # OTE (OpenShift Tests Extension) — used when discovered_openshift_release >= 4.20
 openstack_test_suite: openstack-test/all
 openstack_test_ote_binary_relpath: bin/openstack-test-tests-ext
+# Run filtered OTE tests one-by-one (required for [lb][Serial] under Octavia limits).
+openstack_test_ote_run_serial: false

collection/stages/roles/openstack_test/tasks/run_openstack_test.yml

@@ -169,9 +169,36 @@
               - "{{ openstack_test_junit_path }}"
           changed_when: true
 
-    # OTE run-test has no --junit-path; pipe filtered names via stdin and
-    # synthesize junit from resolved log outcomes for post_openshift_tests.
-    - name: Run OTE filtered tests via run-test and write junit
+    # OTE run-test has no --junit-path; synthesize junit via ote_resolve_results.py.
+    # lb_tests: run serially — piping the list runs many LBs in parallel and hits
+    # Octavia/max-shared-lb timeouts despite [lb][Serial] in test names.
+    - name: Run OTE filtered tests serially via run-test and write junit
+      ansible.builtin.shell: |
+        set -o pipefail
+        : > {{ openstack_test_log_path }}
+        run_exit=0
+        while IFS= read -r test || [[ -n "$test" ]]; do
+          [[ -z "${test// }" ]] && continue
+          if ! {{ openstack_test_executable }} run-test --output=json "$test" \
+            >> {{ openstack_test_log_path }} 2>&1; then
+            run_exit=1
+          fi
+        done < {{ tests_to_run_path }}
+        python3 "{{ openstack_test_ote_resolve_script }}" junit \
+          "{{ openstack_test_log_path }}" "{{ openstack_test_junit_path }}" || py_exit=$?
+        exit ${run_exit:-${py_exit:-0}}
+      environment:
+        OS_CLOUD: "{{ user_cloud }}"
+        KUBECONFIG: "{{ kubeconfig }}"
+        RHOSO_KUBECONFIG: "{{ rhoso_kubeconfig }}"
+        SHIFTSTACK_PASS_FILE: "{{ kubeadmin_password }}"
+      changed_when: true
+      when:
+        - openstack_test_use_ote | bool
+        - openstack_test_filtering | bool
+        - openstack_test_ote_run_serial | bool
+
+    - name: Run OTE filtered tests via run-test (stdin batch) and write junit
       ansible.builtin.shell: |
         set -o pipefail
         cat {{ tests_to_run_path }} | {{ openstack_test_executable }} run-test \
@@ -188,6 +215,7 @@
       when:
         - openstack_test_use_ote | bool
         - openstack_test_filtering | bool
+        - not (openstack_test_ote_run_serial | bool)
 
     - name: Run legacy openstack tests
       ansible.builtin.shell: >