From bdf1c40e8207e92d18860beeb174238fb28cec5b Mon Sep 17 00:00:00 2001 From: Alejandro Hernandez Cordero Date: Wed, 2 Sep 2026 12:13:59 +0200 Subject: [PATCH] rclcpp lifecycle tests: Granular includes and include what you use Signed-off-by: Alejandro Hernandez Cordero --- .../test/benchmark/benchmark_lifecycle_client.cpp | 9 ++++++++- .../test/benchmark/benchmark_lifecycle_node.cpp | 4 +++- rclcpp_lifecycle/test/test_callback_exceptions.cpp | 4 +++- rclcpp_lifecycle/test/test_client.cpp | 4 +++- .../test/test_lifecycle_generic_subscription.cpp | 5 ++++- rclcpp_lifecycle/test/test_lifecycle_node.cpp | 12 +++++++++++- .../test/test_lifecycle_service_client.cpp | 12 +++++++++++- .../test/test_register_custom_callbacks.cpp | 4 +++- rclcpp_lifecycle/test/test_service.cpp | 3 ++- rclcpp_lifecycle/test/test_state_machine_info.cpp | 2 +- 10 files changed, 49 insertions(+), 10 deletions(-) diff --git a/rclcpp_lifecycle/test/benchmark/benchmark_lifecycle_client.cpp b/rclcpp_lifecycle/test/benchmark/benchmark_lifecycle_client.cpp index a383de0bd8..0a3544d682 100644 --- a/rclcpp_lifecycle/test/benchmark/benchmark_lifecycle_client.cpp +++ b/rclcpp_lifecycle/test/benchmark/benchmark_lifecycle_client.cpp @@ -15,8 +15,12 @@ #include #include +#include +#include #include +#include #include +#include #include #include "lifecycle_msgs/msg/state.hpp" @@ -25,7 +29,10 @@ #include "lifecycle_msgs/srv/get_available_transitions.hpp" #include "lifecycle_msgs/srv/get_state.hpp" #include "performance_test_fixture/performance_test_fixture.hpp" -#include "rclcpp/rclcpp.hpp" +#include "rclcpp/client.hpp" +#include "rclcpp/executors/single_threaded_executor.hpp" +#include "rclcpp/node.hpp" +#include "rclcpp/utilities.hpp" #include "rclcpp_lifecycle/lifecycle_node.hpp" /** diff --git a/rclcpp_lifecycle/test/benchmark/benchmark_lifecycle_node.cpp b/rclcpp_lifecycle/test/benchmark/benchmark_lifecycle_node.cpp index 4be9ad13af..4a28832d52 100644 --- a/rclcpp_lifecycle/test/benchmark/benchmark_lifecycle_node.cpp +++ b/rclcpp_lifecycle/test/benchmark/benchmark_lifecycle_node.cpp @@ -16,10 +16,12 @@ #include #include +#include #include "lifecycle_msgs/msg/state.hpp" #include "performance_test_fixture/performance_test_fixture.hpp" -#include "rclcpp/rclcpp.hpp" +#include "rclcpp/node.hpp" +#include "rclcpp/utilities.hpp" #include "rclcpp_lifecycle/lifecycle_node.hpp" /** diff --git a/rclcpp_lifecycle/test/test_callback_exceptions.cpp b/rclcpp_lifecycle/test/test_callback_exceptions.cpp index cd6683459f..00118da12e 100644 --- a/rclcpp_lifecycle/test/test_callback_exceptions.cpp +++ b/rclcpp_lifecycle/test/test_callback_exceptions.cpp @@ -18,10 +18,12 @@ #include #include +#include + #include "lifecycle_msgs/msg/state.hpp" #include "lifecycle_msgs/msg/transition.hpp" -#include "rclcpp/rclcpp.hpp" +#include "rclcpp/utilities.hpp" #include "rclcpp_lifecycle/lifecycle_node.hpp" using lifecycle_msgs::msg::State; diff --git a/rclcpp_lifecycle/test/test_client.cpp b/rclcpp_lifecycle/test/test_client.cpp index f34d71ebfc..ba5d08e37c 100644 --- a/rclcpp_lifecycle/test/test_client.cpp +++ b/rclcpp_lifecycle/test/test_client.cpp @@ -18,8 +18,10 @@ #include #include +#include "rclcpp/create_client.hpp" #include "rclcpp/exceptions.hpp" -#include "rclcpp/rclcpp.hpp" +#include "rclcpp/qos.hpp" +#include "rclcpp/utilities.hpp" #include "rclcpp_lifecycle/lifecycle_node.hpp" #include "rcl_interfaces/srv/list_parameters.hpp" diff --git a/rclcpp_lifecycle/test/test_lifecycle_generic_subscription.cpp b/rclcpp_lifecycle/test/test_lifecycle_generic_subscription.cpp index 938be603cd..b100c7b3ef 100644 --- a/rclcpp_lifecycle/test/test_lifecycle_generic_subscription.cpp +++ b/rclcpp_lifecycle/test/test_lifecycle_generic_subscription.cpp @@ -16,7 +16,10 @@ #include -#include "rclcpp/rclcpp.hpp" +#include "rclcpp/message_info.hpp" +#include "rclcpp/qos.hpp" +#include "rclcpp/serialized_message.hpp" +#include "rclcpp/utilities.hpp" #include "rclcpp_lifecycle/lifecycle_node.hpp" class TestLifecycleGenericSubscription : public ::testing::Test diff --git a/rclcpp_lifecycle/test/test_lifecycle_node.cpp b/rclcpp_lifecycle/test/test_lifecycle_node.cpp index b94bd2fdcd..c69219d965 100644 --- a/rclcpp_lifecycle/test/test_lifecycle_node.cpp +++ b/rclcpp_lifecycle/test/test_lifecycle_node.cpp @@ -22,6 +22,9 @@ #include #include +#include +#include + #include "lifecycle_msgs/msg/state.hpp" #include "lifecycle_msgs/msg/transition.hpp" @@ -29,7 +32,14 @@ #include "rcl_interfaces/srv/get_logger_levels.hpp" #include "rcl_interfaces/srv/set_logger_levels.hpp" -#include "rclcpp/rclcpp.hpp" +#include "rclcpp/callback_group.hpp" +#include "rclcpp/event.hpp" +#include "rclcpp/exceptions.hpp" +#include "rclcpp/node.hpp" +#include "rclcpp/node_options.hpp" +#include "rclcpp/parameter.hpp" +#include "rclcpp/parameter_value.hpp" +#include "rclcpp/utilities.hpp" #include "rclcpp_lifecycle/lifecycle_node.hpp" #include "./mocking_utils/patch.hpp" diff --git a/rclcpp_lifecycle/test/test_lifecycle_service_client.cpp b/rclcpp_lifecycle/test/test_lifecycle_service_client.cpp index dfa2125478..375805c19b 100644 --- a/rclcpp_lifecycle/test/test_lifecycle_service_client.cpp +++ b/rclcpp_lifecycle/test/test_lifecycle_service_client.cpp @@ -28,6 +28,10 @@ #include #include +#include +#include +#include + #include "lifecycle_msgs/msg/state.hpp" #include "lifecycle_msgs/msg/transition.hpp" #include "lifecycle_msgs/msg/transition_description.hpp" @@ -38,8 +42,14 @@ #include "rcl_lifecycle/rcl_lifecycle.h" +#include "rclcpp/client.hpp" +#include "rclcpp/event.hpp" +#include "rclcpp/exceptions.hpp" +#include "rclcpp/executors/single_threaded_executor.hpp" +#include "rclcpp/node.hpp" #include "rclcpp/node_interfaces/node_graph.hpp" -#include "rclcpp/rclcpp.hpp" +#include "rclcpp/parameter.hpp" +#include "rclcpp/utilities.hpp" #include "rclcpp_lifecycle/lifecycle_node.hpp" #include "rcpputils/scope_exit.hpp" diff --git a/rclcpp_lifecycle/test/test_register_custom_callbacks.cpp b/rclcpp_lifecycle/test/test_register_custom_callbacks.cpp index 731e89234a..a9c59a5da9 100644 --- a/rclcpp_lifecycle/test/test_register_custom_callbacks.cpp +++ b/rclcpp_lifecycle/test/test_register_custom_callbacks.cpp @@ -18,10 +18,12 @@ #include #include +#include + #include "lifecycle_msgs/msg/state.hpp" #include "lifecycle_msgs/msg/transition.hpp" -#include "rclcpp/rclcpp.hpp" +#include "rclcpp/utilities.hpp" #include "rclcpp_lifecycle/lifecycle_node.hpp" using lifecycle_msgs::msg::State; diff --git a/rclcpp_lifecycle/test/test_service.cpp b/rclcpp_lifecycle/test/test_service.cpp index caacc27750..c610c1be16 100644 --- a/rclcpp_lifecycle/test/test_service.cpp +++ b/rclcpp_lifecycle/test/test_service.cpp @@ -20,7 +20,8 @@ #include #include "rclcpp/exceptions.hpp" -#include "rclcpp/rclcpp.hpp" +#include "rclcpp/service.hpp" +#include "rclcpp/utilities.hpp" #include "rclcpp_lifecycle/lifecycle_node.hpp" #include "rmw/qos_profiles.h" diff --git a/rclcpp_lifecycle/test/test_state_machine_info.cpp b/rclcpp_lifecycle/test/test_state_machine_info.cpp index addf7d12f1..47bd67acd5 100644 --- a/rclcpp_lifecycle/test/test_state_machine_info.cpp +++ b/rclcpp_lifecycle/test/test_state_machine_info.cpp @@ -21,7 +21,7 @@ #include "lifecycle_msgs/msg/state.hpp" #include "lifecycle_msgs/msg/transition.hpp" -#include "rclcpp/rclcpp.hpp" +#include "rclcpp/utilities.hpp" #include "rclcpp_lifecycle/lifecycle_node.hpp" using lifecycle_msgs::msg::State;