From d22361e860b572be26b71396408fdadb9d6b4944 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Thu, 20 Aug 2026 00:49:57 -0700 Subject: [PATCH] Cover `jsinspector-modern/network:jsinspector_network` with Stable API guards (#57962) Summary: Marks `jsinspector-modern/network` as a private module under the C++ Stable API by adding `#include ` to its four exported headers (`BoundedRequestBuffer.h`, `CdpNetwork.h`, `HttpUtils.h`, `NetworkHandler.h`), and wiring the `React-cxxstableapi` dependency into BUCK and the podspec. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: huntie, cipolleschi Differential Revision: D116026740 --- .../jsinspector-modern/network/BoundedRequestBuffer.h | 2 ++ .../ReactCommon/jsinspector-modern/network/CMakeLists.txt | 3 ++- .../ReactCommon/jsinspector-modern/network/CdpNetwork.h | 2 ++ .../ReactCommon/jsinspector-modern/network/HttpUtils.h | 2 ++ .../ReactCommon/jsinspector-modern/network/NetworkHandler.h | 2 ++ .../network/React-jsinspectornetwork.podspec | 2 ++ 6 files changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/network/BoundedRequestBuffer.h b/packages/react-native/ReactCommon/jsinspector-modern/network/BoundedRequestBuffer.h index a84c728aa1c4..7941efed4db2 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/network/BoundedRequestBuffer.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/network/BoundedRequestBuffer.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/jsinspector-modern/network/CMakeLists.txt b/packages/react-native/ReactCommon/jsinspector-modern/network/CMakeLists.txt index c5d2af857bf8..3aaba8b9d198 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/network/CMakeLists.txt +++ b/packages/react-native/ReactCommon/jsinspector-modern/network/CMakeLists.txt @@ -24,4 +24,5 @@ target_include_directories(jsinspector_network PUBLIC ${REACT_COMMON_DIR}) target_link_libraries(jsinspector_network folly_runtime glog - jsinspector_cdp) + jsinspector_cdp + react_cxxstableapi) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/network/CdpNetwork.h b/packages/react-native/ReactCommon/jsinspector-modern/network/CdpNetwork.h index e017d3a10d6f..371e5dc0d8dd 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/network/CdpNetwork.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/network/CdpNetwork.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include diff --git a/packages/react-native/ReactCommon/jsinspector-modern/network/HttpUtils.h b/packages/react-native/ReactCommon/jsinspector-modern/network/HttpUtils.h index 78cee7663c95..0b4d4bc32db5 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/network/HttpUtils.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/network/HttpUtils.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include diff --git a/packages/react-native/ReactCommon/jsinspector-modern/network/NetworkHandler.h b/packages/react-native/ReactCommon/jsinspector-modern/network/NetworkHandler.h index b71890f495fc..92c451677c69 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/network/NetworkHandler.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/network/NetworkHandler.h @@ -7,6 +7,8 @@ #pragma once +#include + #include "BoundedRequestBuffer.h" #include "CdpNetwork.h" diff --git a/packages/react-native/ReactCommon/jsinspector-modern/network/React-jsinspectornetwork.podspec b/packages/react-native/ReactCommon/jsinspector-modern/network/React-jsinspectornetwork.podspec index 305f80846b36..7bc7ddf067fa 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/network/React-jsinspectornetwork.podspec +++ b/packages/react-native/ReactCommon/jsinspector-modern/network/React-jsinspectornetwork.podspec @@ -48,5 +48,7 @@ Pod::Spec.new do |s| add_rn_third_party_dependencies(s) add_rncore_dependency(s) + s.dependency "React-cxxstableapi" + mark_as_react_native_build(s) end