Skip to content

Commit df0263d

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Cover jsinspector-modern/network:jsinspector_network with Stable API guards (#57962)
Summary: Pull Request resolved: #57962 Marks `jsinspector-modern/network` as a private module under the C++ Stable API by adding `#include <react/cxxstableapi/PrivateGuard.h>` to its four exported headers (`BoundedRequestBuffer.h`, `CdpNetwork.h`, `HttpUtils.h`, `NetworkHandler.h`), and wiring the `React-cxxstableapi` dependency into BUCK and the podspec. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116026740
1 parent 503b658 commit df0263d

6 files changed

Lines changed: 11 additions & 0 deletions

File tree

packages/react-native/ReactCommon/jsinspector-modern/network/BoundedRequestBuffer.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <deque>
1113
#include <memory>
1214
#include <string>

packages/react-native/ReactCommon/jsinspector-modern/network/CdpNetwork.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <folly/dynamic.h>
1113

1214
#include <string>

packages/react-native/ReactCommon/jsinspector-modern/network/HttpUtils.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <map>
1113
#include <string>
1214

packages/react-native/ReactCommon/jsinspector-modern/network/NetworkHandler.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include "BoundedRequestBuffer.h"
1113
#include "CdpNetwork.h"
1214

packages/react-native/ReactCommon/jsinspector-modern/network/React-jsinspectornetwork.podspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,5 +48,7 @@ Pod::Spec.new do |s|
4848
add_rn_third_party_dependencies(s)
4949
add_rncore_dependency(s)
5050

51+
s.dependency "React-cxxstableapi"
52+
5153
mark_as_react_native_build(s)
5254
end

packages/react-native/ReactCommon/react/nativemodule/defaults/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ target_include_directories(react_nativemodule_defaults PUBLIC ${REACT_COMMON_DIR
1515

1616
target_link_libraries(react_nativemodule_defaults
1717
react_codegen_rncore
18+
react_cxxstableapi
1819
react_nativemodule_core
1920
react_nativemodule_dom
2021
react_nativemodule_devtoolsruntimesettings

0 commit comments

Comments
 (0)