Tie the clone form back to the action it posts to

Review follow-ups: the action name the page posts is taken from the
function again, so renaming it cannot leave the form posting an action
that no longer exists (nothing renders this template in tests, so a wrong
name would go unnoticed); the steps keep their qualified name, so a
traceback names the step it came from rather than the decorator; and the
`copied` keys say why they are spelled out instead of derived.

Author: marcoacierno

backend/conferences/admin/actions.py

@@ -140,7 +140,8 @@ def clone_conference(modeladmin, request, queryset):
         form = CloneConferenceForm(request.POST)
 
         if form.is_valid():
-            return start_clone_conference(request, source, form.cleaned_data)
+            start_clone_conference(request, source, form.cleaned_data)
+            return None
     else:
         form = CloneConferenceForm(initial=next_edition_defaults(source))
 
@@ -154,6 +155,9 @@ def clone_conference(modeladmin, request, queryset):
             "media": modeladmin.media + form.media,
             "source": source,
             "form": form,
+            # The page posts back to the changelist, so it has to name the
+            # action; taken from the function so a rename cannot break it.
+            "action_name": clone_conference.__name__,
         },
     )
 

backend/conferences/models/conference.py

@@ -124,7 +124,9 @@ class Conference(GeoLocalizedModel, TimeFramedModel, TimeStampedModel):
         _("max proposals per user"),
         null=True,
         blank=True,
-        help_text=_("Maximum number of proposals a user can submit. Leave empty for no limit."),
+        help_text=_(
+            "Maximum number of proposals a user can submit. Leave empty for no limit."
+        ),
     )
 
     def get_slack_oauth_token(self):

backend/conferences/templates/admin/conferences/clone_conference.html

@@ -27,7 +27,7 @@
         {% csrf_token %}
 
         <input type="hidden" name="_selected_action" value="{{ source.pk }}">
-        <input type="hidden" name="action" value="clone_conference">
+        <input type="hidden" name="action" value="{{ action_name }}">
         <input type="hidden" name="apply" value="1">
 
         <fieldset class="module aligned">

backend/conferences/workflows/clone_conference.py

@@ -115,6 +115,7 @@ def step(ctx: Context, source_code: str, conference_id: int) -> int:
             return fn(source, conference)
 
     step.__name__ = fn.__name__
+    step.__qualname__ = fn.__qualname__
     step.__doc__ = fn.__doc__
 
     return database_step(step)
@@ -461,7 +462,9 @@ def copy_voting_included_events(source: Conference, conference: Conference) -> i
 
 # Everything that only needs the source and the freshly created conference,
 # in the order it is copied. Sponsor levels read the benefits copied just
-# before them, so the order matters.
+# before them, so the order matters. The names are what the workflow reports
+# back as its `copied` counts, so they are spelled out rather than derived from
+# the functions: renaming one should not change what callers read.
 COPY_STEPS = (
     ("deadlines", copy_deadlines),
     ("durations", copy_durations),