PHP 8.5 deprecations

[matjazpotocnik]

Deprecated
: Constant PDO::MYSQL_ATTR_INIT_COMMAND is deprecated since 8.5, use Pdo\Mysql::ATTR_INIT_COMMAND instead in
WireDatabasePDO.php on line 282

Deprecated
: Constant PDO::MYSQL_ATTR_INIT_COMMAND is deprecated since 8.5, use Pdo\Mysql::ATTR_INIT_COMMAND instead in
WireDatabasePDO.php on line 283

[adrianbj]

Thanks for starting this @matjazpotocnik - we're only about 5 weeks from 8.5 release so will be great to get the ball rolling - I am an early adopter when it comes to PHP for sure.

[matjazpotocnik]

Deprecated: The predefined locally scoped $http_response_header variable is deprecated, call http_get_last_response_headers() instead in [C:\inetpub\wwwroot\wire\core\WireHttp.php:713]

Deprecated: The predefined locally scoped $http_response_header variable is deprecated, call http_get_last_response_headers() instead in [C:\inetpub\wwwroot\wire\core\WireHttp.php:1205]

Possible fix:

//if(isset($http_response_header)) $this->setResponseHeader($http_response_header);
$http_response_header = null; //somewhere at the top
if (version_compare(PHP_VERSION, "8.4.0", ">=")) {
    $headers = \http_get_last_response_headers();
} elseif (isset($http_response_header)) {
    $headers = $http_response_header;
}
if (isset($headers)) $this->setResponseHeader($headers);

Deprecated: Function curl_close() is deprecated since 8.5, as it has no effect since PHP 8.0 in [C:\inetpub\wwwroot\wire\core\WireHttp.php:886]

Possible fix:

//curl_close($curl);
if (PHP_MAJOR_VERSION < 8) {
    curl_close($curl);
}

[ryancramerdesign]

@matjazpotocnik Thanks I've pushed fixes for the items above. Though I'm not running PHP 8.5 yet so please let me know if I screwed up anything.

[adrianbj]

@ryancramerdesign - I know PHP is lax with case, but I think you need (or should at least use):
Pdo\Mysql::ATTR_INIT_COMMAND rather than PDO\\Mysql::ATTR_INIT_COMMAND

[matjazpotocnik]

@ryancramerdesign:

your fix for curl doesn't work, in WireHttp.php lines 904 and 1160 stil emit warnings. You can safely change:

if(version_compare(PHP_VERSION, '8.5.0', '=<')) curl_close($curl);

to:

if (PHP_MAJOR_VERSION < 8) curl_close($curl);

since curl_close() has no effect on PHP 8 and higher.

Deprecated: The predefined locally scoped $http_response_header variable is deprecated, call http_get_last_response_headers() instead in [C:\inetpub\wwwroot\wire\core\WireHttp.php:1223]

You fixed one occurence of http headers, but there is another one in downloadFopen() function.

[matjazpotocnik]

Deprecated: Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead in [C:\inetpub\wwwroot\wire\core\WireArray.php:788]

[matjazpotocnik]

Deprecated: Using null as an array offset is deprecated, use an empty string instead in ...\Inputfield\InputfieldAsmSelect\InputfieldAsmSelect.module:257

[ryancramerdesign]

@adrianbj Any idea whether PDO or Pdo is the correct one? I see PHP referring to both.

@matjazpotocnik I want to stick to using version_compare so that these PHP 8.5 checks (and other PHP version checks) are consistent and I can easily execute a find to see them all. If you are running PHP 8.5, I'm not sure why curl_close() would still be getting called in this context?

if(version_compare(PHP_VERSION, '8.5.0', '<')) curl_close($curl);

... in any case, I've changed the version check to 8.0.0, though the PHP docs do say that curl_close() is only deprecated in PHP 8.5 (not PHP 8.0) even if it doesn't do anything. So it's a bit of a mystery why PHP is producing an error for it since we were telling it to call curl_close only in versions prior to 8.5.

I've also fixed the second $http_response_header that I missed before, along with the other items you mentioned. Thanks.

[adrianbj]

@ryancramerdesign - I think for the Mysql subclass it is: Pdo https://www.php.net/manual/en/class.pdo-mysql.php and note that the deprecation warning also says to use: Pdo\Mysql::ATTR_INIT_COMMAND

[adrianbj]

If you are running PHP 8.5, I'm not sure why curl_close() would still be getting called in this context?

Probably because 8.5.0 isn't released yet - we are still in RC territory, so if you want version_compare, then probably 8.0.0 would be the best version to check against.

[matjazpotocnik]

Deprecated: Using null as an array offset is deprecated, use an empty string instead in [C:\inetpub\wwwroot\wire\core\WireArray.php:609]

[matjazpotocnik]

Deprecated: Using null as an array offset is deprecated, use an empty string instead in [C:\inetpub\wwwroot\wire\core\WireArray.php:609]

Fixed in processwire/processwire@08738d9

[adrianbj]

Deprecated: Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead in wire/core/WireArray.php:1253