From 8b1909854d25dba6653201378e440b9150ff42bb Mon Sep 17 00:00:00 2001 From: varunghat Date: Thu, 24 Sep 2026 15:50:14 +0200 Subject: [PATCH 1/2] Removed mwd ISOCODE from the ISO exceptions in test-inventory-metadata.R --- tests/test-inventory-metadata.R | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/tests/test-inventory-metadata.R b/tests/test-inventory-metadata.R index 754db28..a0c275d 100644 --- a/tests/test-inventory-metadata.R +++ b/tests/test-inventory-metadata.R @@ -69,19 +69,6 @@ test_that("ISO codes are valid", { # disambiguates); if glottolog is right then the ISO should # be `laj` - "mwd", # split: http://www.iso639-3.sil.org/code/mwd - # source: https://glottolog.org/resource/reference/id/1921 - # langoid: none associated with source nor current ISO code: - # https://glottolog.org/glottolog?iso=mwd - # our current glottocode `mudb1240` is associated with one half - # of the split (`dmw`). The other half `xrq` (Karranga) has no - # associated langoid: - # https://glottolog.org/glottolog?iso=xrq - # TODO: Double-check that the source really describes Mudburra - # and not Karranga. If it describes both, change nothing - # and keep this exception. If it describes only one, change - # ISO (and possibly glottocode) accordingly. - "qgu", # Extinct. https://glottolog.org/resource/languoid/id/wulg1239 "wit", # split; https://iso639-3.sil.org/request/2012-144 From 609e3173760112fcfad3be1829b38d85919074ff Mon Sep 17 00:00:00 2001 From: varunghat Date: Thu, 24 Sep 2026 16:13:35 +0200 Subject: [PATCH 2/2] Updated test-inventory-metadata to use mismatch_indices to fix false test failure --- tests/test-inventory-metadata.R | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/test-inventory-metadata.R b/tests/test-inventory-metadata.R index a0c275d..8d41c43 100644 --- a/tests/test-inventory-metadata.R +++ b/tests/test-inventory-metadata.R @@ -181,8 +181,7 @@ test_that("glottocodes are valid", { mismatch_glottocodes <- phoible$Glottocode[has_glottocode][mismatch_indices] mismatches <- unique(paste0(mismatch_ids, " (", mismatch_glottocodes, "): ", iso_from_phoible[mismatch_indices], " - ", iso_from_glottolog[mismatch_indices])) - - expect(length(mismatches) == 0, + expect(length(mismatch_indices) == 0, paste("MISMATCHED ISO CODES BETWEEN PHOIBLE AND GLOTTOLOG (InventoryID (glottocode)): phoible - glottolog):", paste0("- ", mismatches, collapse="\n"), sep="\n")