Add Map Labyrinth#3982
Conversation
|
SAM seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (2)
WalkthroughAdds a new Labyrinth map: generator source and runtime manifest, registers the map type, updates playlist frequency to 5, and adds English localization. ChangesLabyrinth Map Addition
Sequence DiagramsequenceDiagram
participant MapGenerator
participant Game
participant MapPlaylist
participant Resources
MapGenerator->>Game: register map key "labyrinth"
Game->>MapPlaylist: surface GameMapType.Labyrinth
MapPlaylist->>MapPlaylist: set FREQUENCY["Labyrinth"] = 5
MapGenerator->>Resources: emit manifest `resources/maps/labyrinth/manifest.json`
Resources->>Game: runtime manifest available for selection
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@map-generator/assets/maps/labyrinth/info.json`:
- Line 191: The "name" value "Saftey" in the map metadata needs to be corrected
to "Safety" to fix the typo; locate the entry in info.json where the JSON
property "name" equals "Saftey" and replace that string with "Safety" so the
player-visible nation name is spelled correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b009bc1e-d965-4b5c-904c-758eb4075d40
⛔ Files ignored due to path filters (4)
map-generator/assets/maps/labyrinth/image.pngis excluded by!**/*.pngresources/maps/labyrinth/map.binis excluded by!**/*.binresources/maps/labyrinth/map16x.binis excluded by!**/*.binresources/maps/labyrinth/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (7)
map-generator/assets/maps/labyrinth/info.jsonmap-generator/main.goresources/lang/en.jsonresources/maps/labyrinth/manifest.jsonresources/maps/labyrinth/thumbnail.webpsrc/core/game/Game.tssrc/server/MapPlaylist.ts
Description:
Labyrinth is a 'maze' style arcade map. Testing shows it lasting over 45min on average in FFA. I have gone through the trouble of programming stable team games for 2, 3, 4, 5, 6, and 7 teams. I worked a while on making sure the game played well by adjusting interconnections between the tiles.
https://www.youtube.com/watch?v=0-yqrfr3nv0
https://discord.com/channels/1284581928254701718/1497062552784605316
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
PlaysBaldy