dns: validate address type in lookupService

Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
PR-URL: #64878
Fixes: #64877
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>

Author: lazerg

lib/dns.js

@@ -84,6 +84,7 @@ const {
   validateNumber,
   validateOneOf,
   validatePort,
+  validateString,
   validateStringWithoutNullBytes,
 } = require('internal/validators');
 
@@ -275,6 +276,8 @@ function lookupService(address, port, callback) {
   if (arguments.length !== 3)
     throw new ERR_MISSING_ARGS('address', 'port', 'callback');
 
+  validateString(address, 'address');
+
   if (isIP(address) === 0)
     throw new ERR_INVALID_ARG_VALUE('address', address);
 

lib/internal/dns/promises.js

@@ -283,6 +283,8 @@ function lookupService(address, port) {
   if (arguments.length !== 2)
     throw new ERR_MISSING_ARGS('address', 'port');
 
+  validateString(address, 'address');
+
   if (isIP(address) === 0)
     throw new ERR_INVALID_ARG_VALUE('address', address);
 

test/parallel/test-dns.js

@@ -344,6 +344,24 @@ dns.lookup('', {
   }, err);
 }
 
+{
+  const invalidAddress = Buffer.from('127.0.0.1');
+  const err = {
+    code: 'ERR_INVALID_ARG_TYPE',
+    name: 'TypeError',
+    message: 'The "address" argument must be of type string. ' +
+    'Received an instance of Buffer'
+  };
+
+  assert.throws(() => {
+    dnsPromises.lookupService(invalidAddress, 0);
+  }, err);
+
+  assert.throws(() => {
+    dns.lookupService(invalidAddress, 0, common.mustNotCall());
+  }, err);
+}
+
 [null, undefined, 65538, 'test', NaN, Infinity, Symbol(), 0n, true, false, '', () => {}, {}].forEach((port) => {
   const err = {
     code: 'ERR_SOCKET_BAD_PORT',