I am working on support for more triggers as part of RigolOscilloscope (#1017). Multiple trigger classes have driver specific properties handling inside them. For example PulseWidthTrigger. In my opinion, this is not scalable approach and all driver specific logic should be in the driver class.
Also PulseWidthTrigger inherits from EdgeTrigger and takes polarity from it's Type. Edge trigger type typically allows rising/falling/any edge, but the option any does not make much sense for PulseWidthTrigger (at least for Rigol).
At this moment, new trigger is set using Oscilloscope::SetTrigger and then pushed to the device using Oscilloscope::PushTrigger.
Solution could be to call new virtual driver function from Oscilloscope::SetTrigger which would update the trigger options (supported edges, supported conditions, etc.) according to driver/device capabilities.
What do you think?
I am working on support for more triggers as part of RigolOscilloscope (#1017). Multiple trigger classes have driver specific properties handling inside them. For example PulseWidthTrigger. In my opinion, this is not scalable approach and all driver specific logic should be in the driver class.
Also
PulseWidthTriggerinherits from EdgeTrigger and takes polarity from it'sType. Edge trigger type typically allowsrising/falling/anyedge, but the optionanydoes not make much sense forPulseWidthTrigger(at least for Rigol).At this moment, new trigger is set using
Oscilloscope::SetTriggerand then pushed to the device usingOscilloscope::PushTrigger.Solution could be to call new virtual driver function from
Oscilloscope::SetTriggerwhich would update the trigger options (supported edges, supported conditions, etc.) according to driver/device capabilities.What do you think?