Skip to content

ANSI escape codes should not be output to terminals that don't support them #17

Description

@ayoungblood

Based on testing ngscopeclient (*.msi installer from e0dd8c5 build) on Windows with various shells:

Command Prompt:
image

Powershell:
image

It seems like there are workarounds/ways to enable ANSI colors (at least in Powershell, less sure about regular cmd.exe), but regardless, ANSI escape codes should be suppressed for terminals that lack support or do not have ANSI colors enabled.

Interestingly, using Microsoft Terminal (microsoft/terminal) with either of these shells supports ANSI colors:

image

image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions