[Bug]: I18n not possible for several classes

[fbausch]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

The classes in /lib/public/Sharing/Property/ do not properly use the t() function for obtaining internationalized strings.
For example, in

server/lib/public/Sharing/Property/ADateSharePropertyType.php

Line 49 in 9514d12

return $l10nFactory->get(Application::APP_ID)->t('Invalid ISO date: ' . $value);

the string for i18n is concatenated, instead of using format strings.

Since

return $l10nFactory->get(Application::APP_ID)->t('Invalid ISO date: ' . $value);

is used, the string showing up in Transifex is Invalid ISO date: .

The correct usage would be something like:

return $l10nFactory->get(Application::APP_ID)->t('Invalid ISO date: %s', [$value]);

Steps to reproduce

1. Log into Transifex
2. Open the Nextcloud lib component and check for the strings of the classes in /lib/public/Sharing/Property/

Expected behavior

Transifex should show strings like

Invalid ISO date: %s

Nextcloud Server version

35 (master)

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

[kesselb]

cc @provokateurin

[provokateurin]

Thanks for the report!

[provokateurin]

#62393

[rakekniven]

@provokateurin Reopening here as this will not work for some languages. We need positional placeholders. See guidelines at https://docs.nextcloud.com/server/latest/developer_manual/basics/translations.html#step-3-placeholders