CI/CD Pipeline False Positives: `import-dir` Exits with Code 0 on Failures

[aniket866]

Describe the bug

Description

The import-dir command scans a directory and attempts to import all matching files. If one or more files fail to import, it records the failure in ImportResult.FailedCount and prints an error message. However, the command runner does not check the failed count to return a non-zero exit code.

Impact

In CI/CD environments (GitHub Actions, Tekton, GitLab CI), the CLI exits with status 0, indicating success even if all API specifications failed to import. This hides deployment failures.

Code Reference

• cmd/importDir.go

Diagram

graph TD
    A[Start import-dir] --> B[Scan Directory]
    B --> C[Import File 1: Success]
    B --> D[Import File 2: FAILED]
    C & D --> E[Display Results Summary]
    E --> F["Exit Status Code 0 (Success)"]
    F --> G["CI/CD pipeline reports green/success despite failures"]

Loading

Steps to Reproduce

1. Run microcks import-dir ./specs where at least one spec has invalid content.
2. The console displays ✗ Failed: ....
3. Check the exit code of the process (echo $? or $LASTEXITCODE in PowerShell). It returns 0.

---

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. Microcks is a Cloud Native Computing Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

[Caesarsage]

Thank you @aniket866

This has been Fixed on master, import-dir now returns a non-zero exit when any file fails: importDirectoryPartialFailure wraps FailedCount > 0 into a KindAPI error that the exit funnel maps to a failure code.

I believe this can be closed.