feat[electrum]: Support server.features on all feature combinations#150
Open
junderw wants to merge 1 commit into
Open
feat[electrum]: Support server.features on all feature combinations#150junderw wants to merge 1 commit into
junderw wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds unconditional support for the Electrum server.features RPC so Electrum/Sparrow clients don’t fail when electrum-discovery is not enabled, aligning behavior with the standard Electrum protocol expectations.
Changes:
- Make
server.featuresavailable regardless ofelectrum-discovery, returning a sharedServerFeaturesstruct per connection. - Always include
electrum_public_hostsinConfig, defaulting toNonewhenelectrum-discoveryis disabled sohostsserializes as an empty map.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/electrum/server.rs | Removes feature-gating for server.features and wires a shared Arc<ServerFeatures> into each connection. |
| src/config.rs | Makes electrum_public_hosts part of Config in all builds, with None when discovery is not compiled in. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #149
Adds the
server.featuresendpoint on electrum regardless of feature flags.If the electrum-discovery feature isn't enabled, the hosts value is an empty HashMap.
At least this will prevent errors when clients attempt to query this.