From e43842d48a5499852fcafc848db2ed79bef910c5 Mon Sep 17 00:00:00 2001
From: Alexander Lisachenko <lisachenko.it@gmail.com>
Date: Wed, 19 Aug 2026 05:32:20 +0000
Subject: [PATCH] test(tests): drop the E_DEPRECATED suppression from the .phpt
 files
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Every .phpt carried a third --INI-- line, error_reporting=E_ALL & ~E_DEPRECATED.
It existed only because z-engine's development line declared implicitly nullable
parameters (ZEngine\Type\OpLine::__construct()); PHPUnit's .phpt runner forces
display_errors=1, so that deprecation was prepended to the captured output of
every test and failed each --EXPECT-- block.

The stable releases now required (~8.4.2 || ~8.5.0) declare those parameters
?Type, so the line suppresses nothing. Removing it also stops the suite from
hiding a genuine deprecation should one ever appear.

ffi.enable=1 and opcache.jit=off stay — those are load-bearing.

Suite verified at 19/19 on PHP 8.4.19 with z-engine 8.4.2 and on PHP 8.5.9 with
z-engine 8.5.0, both before the change (with error_reporting=E_ALL forced over
each file's own --INI--) and after it.

Docs updated to describe two mandatory --INI-- lines: CLAUDE.md ("Running tests",
the anatomy example, the rules bullet) and .claude/agents/phpt-author.md (template
and rules). No source, composer.json or CI change — ci.yml never referenced the
line.

Closes #21

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013foRd1XwLwqjUSkSWeWrMe
---
 .claude/agents/phpt-author.md                 | 14 +++----
 CLAUDE.md                                     | 38 ++++++++++---------
 tests/Functional/testCanAddMatrices.phpt      |  1 -
 .../Functional/testCanCastMatrixToArray.phpt  |  1 -
 tests/Functional/testCanCastMatrixToBool.phpt |  1 -
 ...CastMatrixToNumberUsingEngineFallback.phpt |  1 -
 .../Functional/testCanCastMatrixToString.phpt |  1 -
 .../testCanDivideMatrixByNumber.phpt          |  1 -
 .../testCanMultiplyCompatibleMatrices.phpt    |  1 -
 .../testCanMultiplyMatrixByNumber.phpt        |  1 -
 .../testCanMultiplyNumberByMatrix.phpt        |  1 -
 .../Functional/testCanPowMatrixByNumber.phpt  |  1 -
 tests/Functional/testCanSubtractMatrices.phpt |  1 -
 ...nMultiplicationOfIncompatibleMatrices.phpt |  1 -
 ...testFailsOnAddingIncompatibleMatrices.phpt |  1 -
 tests/Functional/testFailsOnEmptyMatrix.phpt  |  1 -
 tests/Functional/testFailsOnRaggedMatrix.phpt |  1 -
 ...ailsOnSubtractingIncompatibleMatrices.phpt |  1 -
 .../testKeepsDefaultDebugOutput.phpt          |  1 -
 ...VisibilityForClassScopedGetObjectVars.phpt |  1 -
 ...epsPropertyVisibilityForGetObjectVars.phpt |  1 -
 21 files changed, 28 insertions(+), 43 deletions(-)

diff --git a/.claude/agents/phpt-author.md b/.claude/agents/phpt-author.md
index 4b19ca5..380d51a 100644
--- a/.claude/agents/phpt-author.md
+++ b/.claude/agents/phpt-author.md
@@ -23,7 +23,6 @@ One-line description of the behaviour, in the present tense
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
@@ -52,12 +51,13 @@ array(1) {
 
 ## Rules
 
-- **`--INI--` is mandatory, all three lines.** `ffi.enable` cannot be set at runtime, the
-  JIT rewrites the executor internals z-engine hooks, and
-  `error_reporting=E_ALL & ~E_DEPRECATED` hides a deprecation that z-engine `dev-master`
-  itself triggers on PHP 8.4 (implicitly nullable parameters). PHPUnit's `.phpt` runner
-  forces `display_errors=1`, so without that third line the dependency's deprecation is
-  prepended to your captured output and the test fails on noise.
+- **`--INI--` is mandatory, both lines.** `ffi.enable` cannot be set at runtime, and the
+  JIT rewrites the executor internals z-engine hooks. There is no `error_reporting` line
+  any more: it existed only to hide a deprecation z-engine's development line raised
+  (implicitly nullable parameters), and the stable releases this package requires
+  (`~8.4.2 || ~8.5.0`) raise none. Do not add one back — PHPUnit's `.phpt` runner forces
+  `display_errors=1`, so a diagnostic reaching your captured output is real information,
+  not noise to suppress.
 - **An operator cannot throw into userland.** `__doOperation`/`__compare` run inside an FFI
   callback, and PHP 8.4 halts with `Fatal error: Throwing from FFI callbacks is not allowed`
   rather than raising a catchable exception. Never write `try`/`catch` around `$a + $b` in a
diff --git a/CLAUDE.md b/CLAUDE.md
index d1a9fcf..ef770ff 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -31,26 +31,31 @@ say so and stop.
 composer test
 ```
 
-The suite is PHPUnit 12 driving `.phpt` files in `tests/Functional/`. Three INI
+The suite is PHPUnit 12 driving `.phpt` files in `tests/Functional/`. Two INI
 settings must hold in **both** the parent PHPUnit process and every `.phpt` child
 process it spawns:
 
 - `ffi.enable=1` — FFI cannot be turned on at runtime.
 - `opcache.jit=off` — the JIT rewrites the very executor internals z-engine hooks.
-- `error_reporting=E_ALL & ~E_DEPRECATED` — a guard against dependency deprecations
-  leaking into captured output. PHPUnit's `.phpt` runner forces `display_errors=1`,
-  so a deprecation raised by a dependency is prepended to the captured output of
-  **every** test and each `--EXPECT--` block fails on noise that has nothing to do
-  with this library. The specific offender that motivated it — z-engine declaring
-  implicitly nullable parameters (e.g. `ZEngine\Type\OpLine::__construct()`) — is
-  fixed as of the stable releases (`~8.4.2 || ~8.5.0`), and the suite passes with
-  `error_reporting=E_ALL` forced on both minors, so the line is now belt-and-braces
-  rather than a requirement.
+
+Both are load-bearing: PHPUnit's `.phpt` runner forces `display_errors=1`, so
+anything a child process emits before its own output — a startup error, a warning, a
+deprecation from a dependency — is prepended to the captured output and the
+`--EXPECT--` block fails on noise that has nothing to do with this library.
+
+The suite used to carry a third line, `error_reporting=E_ALL & ~E_DEPRECATED`, for
+exactly that reason: z-engine's development line declared implicitly nullable
+parameters (e.g. `ZEngine\Type\OpLine::__construct()`) and PHP reported the
+deprecation into every test's output. The stable releases now required
+(`~8.4.2 || ~8.5.0`) declare those parameters `?Type`, the suite passes with
+`error_reporting=E_ALL` forced on both minors, and the line has been removed. **Do
+not add it back to silence a new diagnostic** — a deprecation appearing in the
+captured output is a signal about a dependency or about this library, and hiding it
+only moves the failure somewhere harder to find.
 
 CI supplies the FFI and JIT pair as `ini-values` on the PHP setup step, and **every
-`.phpt` file carries its own `--INI--` section** — all three lines — so the child
-processes inherit nothing by luck. The deprecation suppression only ever matters in
-the children, because those are the processes whose output is compared.
+`.phpt` file carries its own `--INI--` section** — both lines — so the child
+processes inherit nothing by luck.
 
 For a local one-off run without touching `php.ini`:
 
@@ -93,7 +98,6 @@ Matrices can be added with "+" operator
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
@@ -123,9 +127,9 @@ array(1) {
 
 Rules for a new test:
 
-- `--INI--` is **mandatory, all three lines** — without them the child process has no
-  FFI, runs the JIT over hooked internals, or drowns the expected output in a
-  z-engine deprecation, and the test fails in a way that looks like a library bug.
+- `--INI--` is **mandatory, both lines** — without them the child process has no FFI
+  or runs the JIT over hooked internals, and the test fails in a way that looks like
+  a library bug.
 - Include the autoloader with the relative path `__DIR__ . '/../../vendor/autoload.php'`;
   that is what triggers `bootstrap.php` and installs the handlers.
 - Prefer `--EXPECT--` (exact match). Use `--EXPECTREGEX--` only when the output
diff --git a/tests/Functional/testCanAddMatrices.phpt b/tests/Functional/testCanAddMatrices.phpt
index 5148f64..24d47ed 100644
--- a/tests/Functional/testCanAddMatrices.phpt
+++ b/tests/Functional/testCanAddMatrices.phpt
@@ -3,7 +3,6 @@ Matrices can be added with "+" operator
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testCanCastMatrixToArray.phpt b/tests/Functional/testCanCastMatrixToArray.phpt
index 5f7ee05..2305f3a 100644
--- a/tests/Functional/testCanCastMatrixToArray.phpt
+++ b/tests/Functional/testCanCastMatrixToArray.phpt
@@ -3,7 +3,6 @@ Matrix can be cast to array with "(array)" operator
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testCanCastMatrixToBool.phpt b/tests/Functional/testCanCastMatrixToBool.phpt
index b0a931b..69c20bc 100644
--- a/tests/Functional/testCanCastMatrixToBool.phpt
+++ b/tests/Functional/testCanCastMatrixToBool.phpt
@@ -3,7 +3,6 @@ Matrix can be cast to bool with "(bool)" operator and is always truthy
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testCanCastMatrixToNumberUsingEngineFallback.phpt b/tests/Functional/testCanCastMatrixToNumberUsingEngineFallback.phpt
index 6289062..9dc283f 100644
--- a/tests/Functional/testCanCastMatrixToNumberUsingEngineFallback.phpt
+++ b/tests/Functional/testCanCastMatrixToNumberUsingEngineFallback.phpt
@@ -3,7 +3,6 @@ Numeric casts of a Matrix fall back to the default engine behaviour (warning and
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testCanCastMatrixToString.phpt b/tests/Functional/testCanCastMatrixToString.phpt
index ce0a8d0..3f66866 100644
--- a/tests/Functional/testCanCastMatrixToString.phpt
+++ b/tests/Functional/testCanCastMatrixToString.phpt
@@ -3,7 +3,6 @@ Matrix can be cast to string with "(string)" operator
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testCanDivideMatrixByNumber.phpt b/tests/Functional/testCanDivideMatrixByNumber.phpt
index ca78738..9d8bd84 100644
--- a/tests/Functional/testCanDivideMatrixByNumber.phpt
+++ b/tests/Functional/testCanDivideMatrixByNumber.phpt
@@ -3,7 +3,6 @@ Matrix can be divided by a number with "/" operator
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testCanMultiplyCompatibleMatrices.phpt b/tests/Functional/testCanMultiplyCompatibleMatrices.phpt
index 5f1b6a6..a53cae2 100644
--- a/tests/Functional/testCanMultiplyCompatibleMatrices.phpt
+++ b/tests/Functional/testCanMultiplyCompatibleMatrices.phpt
@@ -3,7 +3,6 @@ Compatible matrices can be multiplied with "*" operator
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testCanMultiplyMatrixByNumber.phpt b/tests/Functional/testCanMultiplyMatrixByNumber.phpt
index 54e97da..76c0e92 100644
--- a/tests/Functional/testCanMultiplyMatrixByNumber.phpt
+++ b/tests/Functional/testCanMultiplyMatrixByNumber.phpt
@@ -3,7 +3,6 @@ Matrix can be multiplied by a number with "*" operator
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testCanMultiplyNumberByMatrix.phpt b/tests/Functional/testCanMultiplyNumberByMatrix.phpt
index d152d36..494c811 100644
--- a/tests/Functional/testCanMultiplyNumberByMatrix.phpt
+++ b/tests/Functional/testCanMultiplyNumberByMatrix.phpt
@@ -3,7 +3,6 @@ Number can be multiplied by a matrix with "*" operator
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testCanPowMatrixByNumber.phpt b/tests/Functional/testCanPowMatrixByNumber.phpt
index c250588..f294423 100644
--- a/tests/Functional/testCanPowMatrixByNumber.phpt
+++ b/tests/Functional/testCanPowMatrixByNumber.phpt
@@ -3,7 +3,6 @@ Matrix can be raised to the power with "**" operator
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testCanSubtractMatrices.phpt b/tests/Functional/testCanSubtractMatrices.phpt
index 4c6ac21..9360532 100644
--- a/tests/Functional/testCanSubtractMatrices.phpt
+++ b/tests/Functional/testCanSubtractMatrices.phpt
@@ -3,7 +3,6 @@ Matrices can be subsctracted with "-" operator
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testFailOnMultiplicationOfIncompatibleMatrices.phpt b/tests/Functional/testFailOnMultiplicationOfIncompatibleMatrices.phpt
index bf9982d..bbe610e 100644
--- a/tests/Functional/testFailOnMultiplicationOfIncompatibleMatrices.phpt
+++ b/tests/Functional/testFailOnMultiplicationOfIncompatibleMatrices.phpt
@@ -3,7 +3,6 @@ Incompatible matrices cannot be multiplied with "*" operator
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testFailsOnAddingIncompatibleMatrices.phpt b/tests/Functional/testFailsOnAddingIncompatibleMatrices.phpt
index d80b950..0849693 100644
--- a/tests/Functional/testFailsOnAddingIncompatibleMatrices.phpt
+++ b/tests/Functional/testFailsOnAddingIncompatibleMatrices.phpt
@@ -3,7 +3,6 @@ Matrices with incompatible dimensions can not be added
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testFailsOnEmptyMatrix.phpt b/tests/Functional/testFailsOnEmptyMatrix.phpt
index 84e2573..42cbad0 100644
--- a/tests/Functional/testFailsOnEmptyMatrix.phpt
+++ b/tests/Functional/testFailsOnEmptyMatrix.phpt
@@ -3,7 +3,6 @@ Matrix can not be created from an empty array
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testFailsOnRaggedMatrix.phpt b/tests/Functional/testFailsOnRaggedMatrix.phpt
index ecdc869..5a82748 100644
--- a/tests/Functional/testFailsOnRaggedMatrix.phpt
+++ b/tests/Functional/testFailsOnRaggedMatrix.phpt
@@ -3,7 +3,6 @@ Matrix can not be created from rows with a different number of columns
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testFailsOnSubtractingIncompatibleMatrices.phpt b/tests/Functional/testFailsOnSubtractingIncompatibleMatrices.phpt
index ba5717a..256845c 100644
--- a/tests/Functional/testFailsOnSubtractingIncompatibleMatrices.phpt
+++ b/tests/Functional/testFailsOnSubtractingIncompatibleMatrices.phpt
@@ -3,7 +3,6 @@ Matrices with incompatible dimensions can not be subtracted
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testKeepsDefaultDebugOutput.phpt b/tests/Functional/testKeepsDefaultDebugOutput.phpt
index 77ec5ef..fad83cf 100644
--- a/tests/Functional/testKeepsDefaultDebugOutput.phpt
+++ b/tests/Functional/testKeepsDefaultDebugOutput.phpt
@@ -3,7 +3,6 @@ Debugging a Matrix keeps the default engine property table with visibility marke
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testKeepsPropertyVisibilityForClassScopedGetObjectVars.phpt b/tests/Functional/testKeepsPropertyVisibilityForClassScopedGetObjectVars.phpt
index fce0e82..fff0e74 100644
--- a/tests/Functional/testKeepsPropertyVisibilityForClassScopedGetObjectVars.phpt
+++ b/tests/Functional/testKeepsPropertyVisibilityForClassScopedGetObjectVars.phpt
@@ -3,7 +3,6 @@ get_object_vars() on a Matrix returns the public view even for class-scoped call
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);
diff --git a/tests/Functional/testKeepsPropertyVisibilityForGetObjectVars.phpt b/tests/Functional/testKeepsPropertyVisibilityForGetObjectVars.phpt
index ee0751d..5076894 100644
--- a/tests/Functional/testKeepsPropertyVisibilityForGetObjectVars.phpt
+++ b/tests/Functional/testKeepsPropertyVisibilityForGetObjectVars.phpt
@@ -3,7 +3,6 @@ get_object_vars() on a Matrix keeps default property visibility for outside call
 --INI--
 ffi.enable=1
 opcache.jit=off
-error_reporting=E_ALL & ~E_DEPRECATED
 --FILE--
 <?php
 declare(strict_types=1);